OpenC3/cosmos

Method get_tlm_values has 38 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    def self.get_tlm_values(items, stale_time: 30, cache_timeout: nil, scope: $openc3_scope)
      now = Time.now
      results = []
      lookups = []
      packet_lookup = {}

Method finish_packet has 38 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    def finish_packet
      if @current_packet
        warnings = @current_packet.check_bit_offsets
        if warnings.length > 0
          raise "Overlapping items not allowed in tables.\n#{warnings}"

Method qfromc has 38 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    def self.qfromc(rotation_matrix)
      tracec = rotation_matrix.trace()
      p = 1.0 + tracec
      if p < 0.0
        p = 0.0

Method _build_cmd_output_string has 38 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    def _build_cmd_output_string(method_name, target_name, cmd_name, cmd_params, packet)
      output_string = "#{method_name}(\""
      output_string << (target_name + ' ' + cmd_name)
      if cmd_params.nil? or cmd_params.empty?
        output_string << '")'

Method calc has 38 lines of code (exceeds 25 allowed). Consider refactoring.

Open

      def calc(data, seed = @seed)
        crc = seed

        case @bit_size
        when 8

Method generate_tool has 38 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    def self.generate_tool(args)
      if args.length < 2 or args.length > 3
        abort("Usage: cli generate #{args[0]} 'Tool Name' (--ruby or --python)")
      end

Method initialize has 38 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    def initialize(port_name = '/dev/ttyS0',
                   baud_rate = 9600,
                   parity = :NONE,
                   stop_bits = 1,
                   write_timeout = 10.0,

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        endpoint = "/openc3-api/packages/#{package_name}?scope=#{scope}"
        uri = URI.parse($api_server.generate_url + endpoint)
        auth = $api_server.generate_auth
        request = Net::HTTP::Delete.new(uri)
        request['User-Agent'] = JsonDRbObject::USER_AGENT

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

python_files.each do |rel_path|
  full_path = File.join(base_path, rel_path)
  data = nil
  File.open(full_path, 'rb') do |file|
    data = file.read

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        state.raw_values.each do |key, value|
          if value
            vals_key = "#{key}__VALS"
            reduced[vals_key] ||= []
            reduced[vals_key] << value

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

gemspec_files.each do |rel_path|
  full_path = File.join(base_path, rel_path)
  data = nil
  File.open(full_path, 'rb') do |file|
    data = file.read

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        state.converted_values.each do |key, value|
          if value
            cvals_key = "#{key}__CVALS"
            reduced[cvals_key] ||= []
            reduced[cvals_key] << value

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        endpoint = "/openc3-api/plugins/#{plugin_name}?scope=#{scope}"
        uri = URI.parse($api_server.generate_url + endpoint)
        auth = $api_server.generate_auth
        request = Net::HTTP::Delete.new(uri)
        request['User-Agent'] = JsonDRbObject::USER_AGENT

• Read up
  Read up

Function set has 12 arguments (exceeds 4 allowed). Consider refactoring.

Open

    def set(

Method set has 12 arguments (exceeds 4 allowed). Consider refactoring.

Open

    def set(target_name, packet_name, item_name, red_low, yellow_low, yellow_high, red_high, green_low = nil, green_high = nil, limits_set = :CUSTOM, persistence = nil, enabled = true)

Method initialize has 12 arguments (exceeds 4 allowed). Consider refactoring.

Open

      hostname,
      port,
      handshake_enabled = true,
      response_timeout = 5.0,
      read_timeout = nil,

Method set_limits has 12 arguments (exceeds 4 allowed). Consider refactoring.

Open

    def set_limits(target_name, packet_name, item_name, red_low, yellow_low, yellow_high, red_high,
                   green_low = nil, green_high = nil, limits_set = 'CUSTOM', persistence = nil, enabled = true,
                   manual: false, scope: $openc3_scope, token: $openc3_token)

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    if (
      // dense, but this accommodates two scenarios:
      // 1. where a completely fresh new line is being inserted in left editor, we want the line on right to stay a 1px line
      // 2. where a new character is inserted at the start of a newline on the left but the line contains other stuff,
      //    we DO want to make it a full line

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    if (
      // dense, but this accommodates two scenarios:
      // 1. where a completely fresh new line is being inserted in left editor, we want the line on right to stay a 1px line
      // 2. where a new character is inserted at the start of a newline on the left but the line contains other stuff,
      //    we DO want to make it a full line

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    def _extract_target_command_names(method_name, *args)
      target_name = nil
      command_name = nil
      case args.length
      when 1

• Read up
  Read up