Sign upLogin

OpenC3/cosmos

View on GitHub
Star
openc3-cosmos-cmd-tlm-api/app/controllers/environment_controller.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method create has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def create
    return unless authorization('script_run')
    if params['key'].nil? || params['value'].nil?
      render json: {
        status: 'error',
Severity: Minor
Found in openc3-cosmos-cmd-tlm-api/app/controllers/environment_controller.rb - About 1 hr to fix

    Identical blocks of code found in 3 locations. Consider refactoring.
    Open

        rescue RuntimeError, JSON::ParserError => e
      logger.error(e.formatted)
      render json: { status: 'error', message: e.message, type: e.class }, status: 400
    rescue TypeError => e
      logger.error(e.formatted)
    Severity: Minor
    Found in openc3-cosmos-cmd-tlm-api/app/controllers/environment_controller.rb and 2 other locations - About 15 mins to fix
    openc3-cosmos-cmd-tlm-api/app/controllers/timeline_controller.rb on lines 74..83
    openc3-cosmos-cmd-tlm-api/app/controllers/timeline_controller.rb on lines 140..149

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 25.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status