Sign upLogin

OpenC3/cosmos

View on GitHub
Star
openc3-cosmos-cmd-tlm-api/app/controllers/storage_controller.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method files has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def files
    return unless authorization('system')
    root = ENV[params[:root]] # Get the actual bucket / volume name
    raise "Unknown bucket / volume #{params[:root]}" unless root
    results = []
Severity: Minor
Found in openc3-cosmos-cmd-tlm-api/app/controllers/storage_controller.rb - About 1 hr to fix

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

      rescue Exception => e
    logger.error(e.formatted)
    OpenC3::Logger.error("Delete failed: #{e.message}", user: username())
    render json: { status: 'error', message: e.message }, status: 500
  end
    Severity: Major
    Found in openc3-cosmos-cmd-tlm-api/app/controllers/storage_controller.rb and 5 other locations - About 25 mins to fix
    openc3-cosmos-cmd-tlm-api/app/controllers/storage_controller.rb on lines 85..89
    openc3-cosmos-cmd-tlm-api/app/controllers/storage_controller.rb on lines 106..110
    openc3-cosmos-cmd-tlm-api/app/controllers/storage_controller.rb on lines 135..139
    openc3-cosmos-cmd-tlm-api/app/controllers/storage_controller.rb on lines 152..156
    openc3-cosmos-cmd-tlm-api/app/controllers/storage_controller.rb on lines 177..181

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 30.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

      rescue Exception => e
    logger.error(e.formatted)
    OpenC3::Logger.error("Upload request failed: #{e.message}", user: username())
    render json: { status: 'error', message: e.message }, status: 500
  end
    Severity: Major
    Found in openc3-cosmos-cmd-tlm-api/app/controllers/storage_controller.rb and 5 other locations - About 25 mins to fix
    openc3-cosmos-cmd-tlm-api/app/controllers/storage_controller.rb on lines 85..89
    openc3-cosmos-cmd-tlm-api/app/controllers/storage_controller.rb on lines 106..110
    openc3-cosmos-cmd-tlm-api/app/controllers/storage_controller.rb on lines 135..139
    openc3-cosmos-cmd-tlm-api/app/controllers/storage_controller.rb on lines 152..156
    openc3-cosmos-cmd-tlm-api/app/controllers/storage_controller.rb on lines 193..197

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 30.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

      rescue Exception => e
    logger.error(e.formatted)
    OpenC3::Logger.error("File exists request failed: #{e.message}", user: username())
    render json: { status: 'error', message: e.message }, status: 500
  end
    Severity: Major
    Found in openc3-cosmos-cmd-tlm-api/app/controllers/storage_controller.rb and 5 other locations - About 25 mins to fix
    openc3-cosmos-cmd-tlm-api/app/controllers/storage_controller.rb on lines 85..89
    openc3-cosmos-cmd-tlm-api/app/controllers/storage_controller.rb on lines 135..139
    openc3-cosmos-cmd-tlm-api/app/controllers/storage_controller.rb on lines 152..156
    openc3-cosmos-cmd-tlm-api/app/controllers/storage_controller.rb on lines 177..181
    openc3-cosmos-cmd-tlm-api/app/controllers/storage_controller.rb on lines 193..197

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 30.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

      rescue Exception => e
    logger.error(e.formatted)
    OpenC3::Logger.error("Download request failed: #{e.message}", user: username())
    render json: { status: 'error', message: e.message }, status: 500
  end
    Severity: Major
    Found in openc3-cosmos-cmd-tlm-api/app/controllers/storage_controller.rb and 5 other locations - About 25 mins to fix
    openc3-cosmos-cmd-tlm-api/app/controllers/storage_controller.rb on lines 85..89
    openc3-cosmos-cmd-tlm-api/app/controllers/storage_controller.rb on lines 106..110
    openc3-cosmos-cmd-tlm-api/app/controllers/storage_controller.rb on lines 135..139
    openc3-cosmos-cmd-tlm-api/app/controllers/storage_controller.rb on lines 177..181
    openc3-cosmos-cmd-tlm-api/app/controllers/storage_controller.rb on lines 193..197

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 30.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

      rescue Exception => e
    logger.error(e.formatted)
    OpenC3::Logger.error("Download failed: #{e.message}", user: username())
    render json: { status: 'error', message: e.message }, status: 500
  end
    Severity: Major
    Found in openc3-cosmos-cmd-tlm-api/app/controllers/storage_controller.rb and 5 other locations - About 25 mins to fix
    openc3-cosmos-cmd-tlm-api/app/controllers/storage_controller.rb on lines 85..89
    openc3-cosmos-cmd-tlm-api/app/controllers/storage_controller.rb on lines 106..110
    openc3-cosmos-cmd-tlm-api/app/controllers/storage_controller.rb on lines 152..156
    openc3-cosmos-cmd-tlm-api/app/controllers/storage_controller.rb on lines 177..181
    openc3-cosmos-cmd-tlm-api/app/controllers/storage_controller.rb on lines 193..197

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 30.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

      rescue Exception => e
    logger.error(e.formatted)
    OpenC3::Logger.error("File listing failed: #{e.message}", user: username())
    render json: { status: 'error', message: e.message }, status: 500
  end
    Severity: Major
    Found in openc3-cosmos-cmd-tlm-api/app/controllers/storage_controller.rb and 5 other locations - About 25 mins to fix
    openc3-cosmos-cmd-tlm-api/app/controllers/storage_controller.rb on lines 106..110
    openc3-cosmos-cmd-tlm-api/app/controllers/storage_controller.rb on lines 135..139
    openc3-cosmos-cmd-tlm-api/app/controllers/storage_controller.rb on lines 152..156
    openc3-cosmos-cmd-tlm-api/app/controllers/storage_controller.rb on lines 177..181
    openc3-cosmos-cmd-tlm-api/app/controllers/storage_controller.rb on lines 193..197

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 30.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status