Sign upLogin

OpenC3/cosmos

View on GitHub
Star
openc3-cosmos-cmd-tlm-api/app/models/message_file_reader.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method next_log_entry has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def next_log_entry
    next_time = nil
    next_reader = nil
    closed_readers = nil
    @open_readers.each do |reader|
Severity: Minor
Found in openc3-cosmos-cmd-tlm-api/app/models/message_file_reader.rb - About 1 hr to fix

    Method open_current_files has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def open_current_files
    opened_files = nil
    if not @file_list[0]
      if @extend_file_list
        # See if any new files have showed up once
    Severity: Minor
    Found in openc3-cosmos-cmd-tlm-api/app/models/message_file_reader.rb - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        def get_file_times(bucket_path)
    basename = File.basename(bucket_path)
    file_start_timestamp, file_end_timestamp, other = basename.split("__")
    file_start_time_object = DateTime.strptime(file_start_timestamp, FILE_TIMESTAMP_FORMAT).to_time
    file_end_time_object = DateTime.strptime(file_end_timestamp, FILE_TIMESTAMP_FORMAT).to_time
      Severity: Minor
      Found in openc3-cosmos-cmd-tlm-api/app/models/message_file_reader.rb and 1 other location - About 25 mins to fix
      openc3-cosmos-cmd-tlm-api/app/models/streaming_object_file_reader.rb on lines 163..168

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 31.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

            if time
        if next_time.nil? or time < next_time
          next_time = time
          next_reader = reader
        end
      Severity: Minor
      Found in openc3-cosmos-cmd-tlm-api/app/models/message_file_reader.rb and 1 other location - About 20 mins to fix
      openc3-cosmos-cmd-tlm-api/app/models/streaming_object_file_reader.rb on lines 109..118

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 28.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status