Sign upLogin

OpenHPS/openhps-imu

View on GitHub
Star

Showing 13 of 13 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public initFilter(object: DataObject, frame: DataFrame): Promise<any> {
        return new Promise<any>((resolve, reject) => {
            if (!frame.getSensor(Accelerometer) && !frame.getSensor(LinearAccelerationSensor)) {
                return reject(new Error(`Acceleration processing requires accelerometer readings!`));
            }
Severity: Major
Found in src/nodes/processing/AccelerationProcessingNode.ts and 1 other location - About 4 hrs to fix
src/nodes/processing/RelativeOrientationProcessingNode.ts on lines 17..29

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 120.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public initFilter(_: DataObject, frame: DataFrame): Promise<any> {
        return new Promise<any>((resolve, reject) => {
            if (!frame.getSensor(Gyroscope) || !frame.getSensor(Accelerometer)) {
                return reject(new Error(`Relative rotation processing requires accelerometer and gyroscope readings!`));
            }
Severity: Major
Found in src/nodes/processing/RelativeOrientationProcessingNode.ts and 1 other location - About 4 hrs to fix
src/nodes/processing/AccelerationProcessingNode.ts on lines 16..28

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 120.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function processPedometer has 56 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public processPedometer(data: PedometerData): Promise<number[]> {
        return new Promise((resolve) => {
            // Factor in the sampling time
            const windowSize = Math.floor(this.options.windowSize * data.frequency);
            const taoMin = this.options.minStepTime * data.frequency;
Severity: Major
Found in src/nodes/processing/PedometerProcessingNode.ts - About 2 hrs to fix

    Function process has 52 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public process(frame: DataFrame): Promise<DataFrame> {
        return new Promise((resolve, reject) => {
            // Get node data for this source object
            let pedometerData: PedometerData;
            this.getNodeData(frame.source)
    Severity: Major
    Found in src/nodes/processing/PedometerProcessingNode.ts - About 2 hrs to fix

      Function processObject has 52 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public processObject(object: DataObject, frame: DataFrame): Promise<DataObject> {
        return new Promise((resolve, reject) => {
            const magnetometer = frame.getSensor(Magnetometer);
            if (!magnetometer) {
                return resolve(object);
      Severity: Major
      Found in src/nodes/processing/calibration/MagnetometerCalibrationNode.ts - About 2 hrs to fix

        Function calibrate has 50 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            calibrate(time: number, userAction: (step: IMUCalibrationStep, error?: Error) => Promise<void>): Promise<void> {
        return new Promise((resolve, reject) => {
            // Calibration data
            let accelerometer: Accelerometer;
            let gyroscope: Gyroscope;
        Severity: Minor
        Found in src/services/IMUCalibrationService.ts - About 2 hrs to fix

          Function applyVelocity has 49 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public applyVelocity(object: DataObject, frame: InOut): Promise<DataObject> {
        return new Promise((resolve) => {
            const lastPosition = object.getPosition();
            // Time since current calculation and previous velocity
            const deltaTime = TimeService.getUnit().convert(
          Severity: Minor
          Found in src/nodes/processing/VelocityProcessingNode.ts - About 1 hr to fix

            Function filter has 30 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public filter(object: DataObject, frame: DataFrame): Promise<DataObject> {
        return new Promise<DataObject>((resolve) => {
            let method: GravityProcessingMethod = this.options.method;

            if (method === undefined) {
            Severity: Minor
            Found in src/nodes/processing/GravityProcessingNode.ts - About 1 hr to fix

              Function bundle has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
              Open

              const bundle = (env, module) => ({
  name: PROJECT_NAME,
  entry: `./dist/${module ? "esm" : "cjs"}/index.js`,
  output: {
    path: path.resolve(__dirname, 'dist'),
              Severity: Minor
              Found in webpack.config.js - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function predictVelocity has 27 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public predictVelocity(object: DataObject): Promise<DataObject> {
        return new Promise((resolve) => {
            const service = this.model.findDataService(object);
            const position = object.getPosition();
            // Get the previous position
              Severity: Minor
              Found in src/nodes/processing/VelocityCalculationNode.ts - About 1 hr to fix

                Function calibrateAccelerometer has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    protected calibrateAccelerometer(
        accelerometer: Accelerometer,
        data: Map<IMUCalibrationStep, Acceleration[]>,
    ): Promise<void> {
        return new Promise((resolve) => {
                Severity: Minor
                Found in src/services/IMUCalibrationService.ts - About 1 hr to fix

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                              let windowMax = Math.max(this.options.minPeak, Math.min(this.options.maxPeak, Math.max(...window)));
                  Severity: Minor
                  Found in src/nodes/processing/PedometerProcessingNode.ts and 1 other location - About 30 mins to fix
                  src/nodes/processing/PedometerProcessingNode.ts on lines 159..159

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 45.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                                      windowMax = Math.max(this.options.minPeak, Math.min(this.options.maxPeak, Math.max(...window)));
                  Severity: Minor
                  Found in src/nodes/processing/PedometerProcessingNode.ts and 1 other location - About 30 mins to fix
                  src/nodes/processing/PedometerProcessingNode.ts on lines 124..124

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 45.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Severity
                  Category
                  Status
                  Source
                  Language