Opetushallitus/eperusteet-opintopolku

View on GitHub

Showing 173 of 607 total issues

File fakedata.ts has 1530 lines of code (exceeds 250 allowed). Consider refactoring.
Open

angular.module("app").factory("fakeData", function() {
    var OPSotsikot = {
        id: 14452,
        tekstiKappale: null,
        omistussuhde: "oma",

    Function mockRakenne has 744 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export function mockRakenne() {
      return {
        'kuvaus': {
          '_tunniste': '1869c9e3-40ec-4d8d-b678-753e5c8ed80a',
          'fi': '<p>Tieto- ja tietoliikennetekniikan perustutkinnon laajuus on 180 osaamispistettä. Tutkinto muodostuu ammatillisista tutkinnon osista (145 osaamispistettä) ja yhteisistä tutkinnon osista (35 osaamispistettä). Ammatillisista tutkinnon osista pakollisia on 85—105 osaamispistettä ja valinnaisia 40—60 osaamispistettä.</p>\n\n<p>Tieto- ja tietoliikennetekniikan perustutkinnon tutkintonimikkeet ovat elektroniikka-asentaja, ICT-asentaja ja hyvinvointiteknologia-asentaja.</p>',
    Severity: Major
    Found in src/components/EpAmmatillinen/tests/data.ts - About 3 days to fix

      File router.ts has 931 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      import _ from 'lodash';
      import Vue from 'vue';
      import Router from 'vue-router';
      import VueScrollTo from 'vue-scrollto';
      import VueMeta from 'vue-meta';
      Severity: Major
      Found in src/router.ts - About 2 days to fix

        File data.ts has 746 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        export function mockRakenne() {
          return {
            'kuvaus': {
              '_tunniste': '1869c9e3-40ec-4d8d-b678-753e5c8ed80a',
              'fi': '<p>Tieto- ja tietoliikennetekniikan perustutkinnon laajuus on 180 osaamispistettä. Tutkinto muodostuu ammatillisista tutkinnon osista (145 osaamispistettä) ja yhteisistä tutkinnon osista (35 osaamispistettä). Ammatillisista tutkinnon osista pakollisia on 85—105 osaamispistettä ja valinnaisia 40—60 osaamispistettä.</p>\n\n<p>Tieto- ja tietoliikennetekniikan perustutkinnon tutkintonimikkeet ovat elektroniikka-asentaja, ICT-asentaja ja hyvinvointiteknologia-asentaja.</p>',
        Severity: Major
        Found in src/components/EpAmmatillinen/tests/data.ts - About 1 day to fix

          File state.ts has 677 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          /*
           * Copyright (c) 2017 The Finnish Board of Education - Opetushallitus
           *
           * This program is free software: Licensed under the EUPL, Version 1.1 or - as
           * soon as they will be approved by the European Commission - subsequent versions

            Function setState has 293 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                    this.setState = function(navi) {
                        this.state = {};
                        _.each(navi.sections, function(section) {
                            section.$open = false;
                            _.each(section.items, function(item) {

              Function epPerusopetusController has 281 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  export const epPerusopetusController = (
                      $q,
                      $scope,
                      $timeout,
                      sisalto,

                Function epLukioSivuNaviController has a Cognitive Complexity of 64 (exceeds 5 allowed). Consider refactoring.
                Open

                    export const epLukioSivuNaviController = (
                        $rootScope,
                        $scope,
                        $location,
                        $state,

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function epSivuNaviController has a Cognitive Complexity of 63 (exceeds 5 allowed). Consider refactoring.
                Open

                    export const epSivuNaviController = (
                        $scope,
                        $state,
                        Algoritmit,
                        Utils,

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                File murupolku.ts has 573 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                /*
                 * Copyright (c) 2013 The Finnish Board of Education - Opetushallitus
                 *
                 * This program is free software: Licensed under the EUPL, Version 1.1 or - as
                 * soon as they will be approved by the European Commission - subsequent versions

                  Function controller has 219 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                                  controller(
                                      $q,
                                      $scope,
                                      $rootScope,
                                      $state,

                    Function controller has 208 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                                    controller(
                                        $q,
                                        $scope,
                                        $rootScope,
                                        $state,

                      Function HakuController has 202 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          export const HakuController = (
                              $scope,
                              $rootScope,
                              $state,
                              SpinnerService,
                      Severity: Major
                      Found in eperusteet-opintopolku-app/yo/app/scripts/views/haku/haku.ts - About 1 day to fix

                        Function epLukioSivuNaviController has 183 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            export const epLukioSivuNaviController = (
                                $rootScope,
                                $scope,
                                $location,
                                $state,

                          Function epSivuNaviController has 178 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              export const epSivuNaviController = (
                                  $scope,
                                  $state,
                                  Algoritmit,
                                  Utils,

                            File lukio.ts has 460 lines of code (exceeds 250 allowed). Consider refactoring.
                            Open

                            /*
                             * Copyright (c) 2013 The Finnish Board of Education - Opetushallitus
                             *
                             * This program is free software: Licensed under the EUPL, Version 1.1 or - as
                             * soon as they will be approved by the European Commission - subsequent versions

                              File state.ts has 449 lines of code (exceeds 250 allowed). Consider refactoring.
                              Open

                              angular.module("app").config($stateProvider => {
                                  const YksinkertaistenResolve = {
                                      viiteId: function(serviceConfig, $stateParams) {
                                          return $stateParams.tekstikappaleId;
                                      },
                              Severity: Minor
                              Found in eperusteet-opintopolku-app/yo/app/states/ops/state.ts - About 6 hrs to fix

                                Function epLukioOppiaineController has a Cognitive Complexity of 43 (exceeds 5 allowed). Consider refactoring.
                                Open

                                    export const epLukioOppiaineController = (
                                        $scope,
                                        $location,
                                        epLukioStateService,
                                        Utils,

                                Cognitive Complexity

                                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                A method's cognitive complexity is based on a few simple rules:

                                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                • Code is considered more complex for each "break in the linear flow of the code"
                                • Code is considered more complex when "flow breaking structures are nested"

                                Further reading

                                File tree.ts has 434 lines of code (exceeds 250 allowed). Consider refactoring.
                                Open

                                /*
                                 * Copyright (c) 2013 The Finnish Board of Education - Opetushallitus
                                 *
                                 * This program is free software: Licensed under the EUPL, Version 1.1 or - as
                                 * soon as they will be approved by the European Commission - subsequent versions
                                Severity: Minor
                                Found in eperusteet-opintopolku-app/yo/app/scripts/peruste/directives/tree.ts - About 6 hrs to fix

                                  File perusopetus.ts has 433 lines of code (exceeds 250 allowed). Consider refactoring.
                                  Open

                                  /*
                                   * Copyright (c) 2013 The Finnish Board of Education - Opetushallitus
                                   *
                                   * This program is free software: Licensed under the EUPL, Version 1.1 or - as
                                   * soon as they will be approved by the European Commission - subsequent versions
                                  Severity: Minor
                                  Found in eperusteet-opintopolku-app/yo/app/scripts/views/ops/perusopetus.ts - About 6 hrs to fix
                                    Severity
                                    Category
                                    Status
                                    Source
                                    Language