Showing 15 of 18 total issues
Function deleteDirectoryRecursive
has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring. Open
public function deleteDirectoryRecursive(string $path, bool $safeDelete = true): bool
{
$path = $this->getAbsolutePathFromRelative($path);
if (empty($path)) {
return false;
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method writeFile
has 37 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function writeFile(
string $path,
string $content,
bool $minifyHtml
): bool {
Method deleteDirectoryRecursive
has 31 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function deleteDirectoryRecursive(string $path, bool $safeDelete = true): bool
{
$path = $this->getAbsolutePathFromRelative($path);
if (empty($path)) {
return false;
Function writeFile
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
public function writeFile(
string $path,
string $content,
bool $minifyHtml
): bool {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function getElement
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
public function getElement(string $path, ?string $type = null)
{
if (null === $type) {
$basePath = $path . '/';
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function getEntriesList
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
public function getEntriesList($parent = null)
{
$filesList = $this->finder->getFilesList();
$basePath = $this->finder->getRealCacheDir();
$basePathLength = \mb_strlen($basePath);
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function isCacheable
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
public function isCacheable(Request $request, Response $response)
{
if (!$this->supercacheEnabled) {
return CacheManager::UNCACHEABLE_DISABLED;
}
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid too many return
statements within this method. Open
return null;
Avoid too many return
statements within this method. Open
return CacheManager::UNCACHEABLE_NO_STORE_POLICY;
Avoid too many return
statements within this method. Open
return CacheManager::UNCACHEABLE_PRIVATE;
Avoid too many return
statements within this method. Open
return CacheManager::UNCACHEABLE_CODE;
Avoid too many return
statements within this method. Open
return true;
Refactor this function to reduce its Cognitive Complexity from 19 to the 15 allowed. Open
public function deleteDirectoryRecursive(string $path, bool $safeDelete = true): bool
- Read upRead up
- Exclude checks
Cognitive Complexity is a measure of how hard the control flow of a function is to understand. Functions with high Cognitive Complexity will be difficult to maintain.
See
Reduce the number of returns of this function 5, down to the maximum allowed 3. Open
public function getElement(string $path, ?string $type = null)
- Read upRead up
- Exclude checks
Having too many return statements in a function increases the function's essential complexity because the flow of execution is broken each time a return statement is encountered. This makes it harder to read and understand the logic of the function.
Noncompliant Code Example
With the default threshold of 3:
function myFunction(){ // Noncompliant as there are 4 return statements if (condition1) { return true; } else { if (condition2) { return false; } else { return true; } } return false; }
Reduce the number of returns of this function 8, down to the maximum allowed 3. Open
public function isCacheable(Request $request, Response $response)
- Read upRead up
- Exclude checks
Having too many return statements in a function increases the function's essential complexity because the flow of execution is broken each time a return statement is encountered. This makes it harder to read and understand the logic of the function.
Noncompliant Code Example
With the default threshold of 3:
function myFunction(){ // Noncompliant as there are 4 return statements if (condition1) { return true; } else { if (condition2) { return false; } else { return true; } } return false; }