PabloKowalczyk/SupercacheBundle

View on GitHub

Showing 12 of 18 total issues

Function deleteDirectoryRecursive has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

    public function deleteDirectoryRecursive(string $path, bool $safeDelete = true): bool
    {
        $path = $this->getAbsolutePathFromRelative($path);
        if (empty($path)) {
            return false;
Severity: Minor
Found in src/Filesystem/Finder.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method writeFile has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function writeFile(
        string $path,
        string $content,
        bool $minifyHtml
    ): bool {
Severity: Minor
Found in src/Filesystem/Finder.php - About 1 hr to fix

    Method deleteDirectoryRecursive has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function deleteDirectoryRecursive(string $path, bool $safeDelete = true): bool
        {
            $path = $this->getAbsolutePathFromRelative($path);
            if (empty($path)) {
                return false;
    Severity: Minor
    Found in src/Filesystem/Finder.php - About 1 hr to fix

      Function writeFile has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          public function writeFile(
              string $path,
              string $content,
              bool $minifyHtml
          ): bool {
      Severity: Minor
      Found in src/Filesystem/Finder.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getElement has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          public function getElement(string $path, ?string $type = null)
          {
              if (null === $type) {
                  $basePath = $path . '/';
      
      
      Severity: Minor
      Found in src/Cache/CacheManager.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function isCacheable has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          public function isCacheable(Request $request, Response $response)
          {
              if (!$this->supercacheEnabled) {
                  return CacheManager::UNCACHEABLE_DISABLED;
              }
      Severity: Minor
      Found in src/Cache/ResponseHandler.php - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getEntriesList has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          public function getEntriesList($parent = null)
          {
              $filesList = $this->finder->getFilesList();
              $basePath = $this->finder->getRealCacheDir();
              $basePathLength = \mb_strlen($basePath);
      Severity: Minor
      Found in src/Cache/CacheManager.php - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

              return true;
      Severity: Major
      Found in src/Cache/ResponseHandler.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                    return CacheManager::UNCACHEABLE_NO_STORE_POLICY;
        Severity: Major
        Found in src/Cache/ResponseHandler.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                  return null;
          Severity: Major
          Found in src/Cache/CacheManager.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                        return CacheManager::UNCACHEABLE_PRIVATE;
            Severity: Major
            Found in src/Cache/ResponseHandler.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                          return CacheManager::UNCACHEABLE_CODE;
              Severity: Major
              Found in src/Cache/ResponseHandler.php - About 30 mins to fix
                Severity
                Category
                Status
                Source
                Language