Sign upLogin

PokemonTCG/pokemon-tcg-sdk-php

View on GitHub
Star

Showing 9 of 9 total issues

Card has 52 functions (exceeds 20 allowed). Consider refactoring.
Open

class Card extends Model
{

    /**
     * @var string
Severity: Major
Found in src/Models/Card.php - About 7 hrs to fix

    CardMarketPrices has 30 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class CardMarketPrices extends Model
{

    /** @var float|null */
    private $averageSellPrice;
    Severity: Minor
    Found in src/Models/CardMarketPrices.php - About 3 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          private static function getJsonResource($type): ResourceInterface
    {
        if (!array_key_exists($type, self::$cache['resources']) || self::haveOptionsBeenUpdated($type, self::$options)) {
            self::$cache['options'][$type] = self::$options;
            self::$cache['resources'][$type] = new JsonResource($type, self::$options, self::$apiKey);
      Severity: Major
      Found in src/Pokemon.php and 1 other location - About 2 hrs to fix
      src/Pokemon.php on lines 109..116

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 124.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          private static function getQueriableResource($type): QueriableResourceInterface
    {
        if (!array_key_exists($type, self::$cache['resources']) || self::haveOptionsBeenUpdated($type, self::$options)) {
            self::$cache['options'][$type] = self::$options;
            self::$cache['resources'][$type] = new QueryableResource($type, self::$options, self::$apiKey);
      Severity: Major
      Found in src/Pokemon.php and 1 other location - About 2 hrs to fix
      src/Pokemon.php on lines 122..129

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 124.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function toArray has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
      Open

          public function toArray()
    {
        $array = [];
        $attributes = $this->getAttributes();
        if (!empty($attributes)) {
      Severity: Minor
      Found in src/Models/Model.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function fill has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

          public function fill(stdClass $data)
    {
        foreach ($data as $attribute => $value) {

            if (is_array($value)) {
      Severity: Minor
      Found in src/Models/Model.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method parse has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function parse($attribute, $value)
    {
        $inflector = InflectorFactory::create()->build();

        if (is_object($value)) {
      Severity: Minor
      Found in src/Models/Model.php - About 1 hr to fix

        Method prepare has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            protected function prepare(): Request
    {
        $uri = $this->resource;

        if (!empty($this->identifier)) {
        Severity: Minor
        Found in src/Resources/QueryableResource.php - About 1 hr to fix

          Function parse has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

              protected function parse($attribute, $value)
    {
        $inflector = InflectorFactory::create()->build();

        if (is_object($value)) {
          Severity: Minor
          Found in src/Models/Model.php - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language