Sign upLogin

PokemonTCG/pokemon-tcg-sdk-php

View on GitHub
Star

Showing 7 of 9 total issues

Card has 52 functions (exceeds 20 allowed). Consider refactoring.
Open

class Card extends Model
{

    /**
     * @var string
Severity: Major
Found in src/Models/Card.php - About 7 hrs to fix

    CardMarketPrices has 30 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class CardMarketPrices extends Model
{

    /** @var float|null */
    private $averageSellPrice;
    Severity: Minor
    Found in src/Models/CardMarketPrices.php - About 3 hrs to fix

      Function toArray has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
      Open

          public function toArray()
    {
        $array = [];
        $attributes = $this->getAttributes();
        if (!empty($attributes)) {
      Severity: Minor
      Found in src/Models/Model.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function fill has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

          public function fill(stdClass $data)
    {
        foreach ($data as $attribute => $value) {

            if (is_array($value)) {
      Severity: Minor
      Found in src/Models/Model.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method parse has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function parse($attribute, $value)
    {
        $inflector = InflectorFactory::create()->build();

        if (is_object($value)) {
      Severity: Minor
      Found in src/Models/Model.php - About 1 hr to fix

        Method prepare has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            protected function prepare(): Request
    {
        $uri = $this->resource;

        if (!empty($this->identifier)) {
        Severity: Minor
        Found in src/Resources/QueryableResource.php - About 1 hr to fix

          Function parse has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

              protected function parse($attribute, $value)
    {
        $inflector = InflectorFactory::create()->build();

        if (is_object($value)) {
          Severity: Minor
          Found in src/Models/Model.php - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language