Sign upLogin

Promact/slack-erp-custom-integration-mvc

View on GitHub
Star
Slack.Automation/Promact.Core.Repository/RedmineRepository/RedmineRepository.cs

Summary

Maintainability
D
2 days
Test Coverage

File RedmineRepository.cs has 401 lines of code (exceeds 250 allowed). Consider refactoring.
Open

using System;
using System.Threading.Tasks;
using Promact.Erp.DomainModel.ApplicationClass.SlackRequestAndResponse;
using Promact.Erp.DomainModel.DataRepository;
using Promact.Erp.DomainModel.Models;
Severity: Minor
Found in Slack.Automation/Promact.Core.Repository/RedmineRepository/RedmineRepository.cs - About 5 hrs to fix

    Method SlackRequestAsync has 84 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            public async Task SlackRequestAsync(SlashCommand slashCommand)
        {
            // Way to break string by spaces only if spaces are not between quotes
            var text = _attachmentRepository.SlackText(slashCommand.Text);
            // Get user details from SlackUserId
    Severity: Major
    Found in Slack.Automation/Promact.Core.Repository/RedmineRepository/RedmineRepository.cs - About 3 hrs to fix

      Method SlackRequestAsync has a Cognitive Complexity of 35 (exceeds 20 allowed). Consider refactoring.
      Open

              public async Task SlackRequestAsync(SlashCommand slashCommand)
        {
            // Way to break string by spaces only if spaces are not between quotes
            var text = _attachmentRepository.SlackText(slashCommand.Text);
            // Get user details from SlackUserId
      Severity: Minor
      Found in Slack.Automation/Promact.Core.Repository/RedmineRepository/RedmineRepository.cs - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method AddTimeEntryToRedmineIssue has 47 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              private async Task AddTimeEntryToRedmineIssue(ApplicationUser user, List<string> text)
        {
            int issueId;
            string result;
            if (ToCheckIssueExistOrNot(text[2], user.RedmineApiKey, out issueId, out result))
      Severity: Minor
      Found in Slack.Automation/Promact.Core.Repository/RedmineRepository/RedmineRepository.cs - About 1 hr to fix

        Method CreateRedmineIssue has 45 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                private async Task CreateRedmineIssue(ApplicationUser user, List<string> text)
        {
            Priority priorityId;
            Status statusId;
            Tracker trackerId;
        Severity: Minor
        Found in Slack.Automation/Promact.Core.Repository/RedmineRepository/RedmineRepository.cs - About 1 hr to fix

          Method UpdateByPropertyAsync has 31 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  private async Task UpdateByPropertyAsync(bool isClose, int assignTo, string issueStringId, string userRedmineApiKey)
        {
            int issueId;
            string result;
            if (ToCheckIssueExistOrNot(issueStringId, userRedmineApiKey, out issueId, out result))
          Severity: Minor
          Found in Slack.Automation/Promact.Core.Repository/RedmineRepository/RedmineRepository.cs - About 1 hr to fix

            Avoid deeply nested control flow statements.
            Open

                                            case SlackAction.issues:
                                    {
                                        RedmineAction redmineAction;
                                        if (RedmineAction.TryParse(text[1], out redmineAction))
                                        {
            Severity: Major
            Found in Slack.Automation/Promact.Core.Repository/RedmineRepository/RedmineRepository.cs - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                                              case SlackAction.projects:
                                    await GetRedmineProjectList(user);
                                    break;
              Severity: Major
              Found in Slack.Automation/Promact.Core.Repository/RedmineRepository/RedmineRepository.cs - About 45 mins to fix

                Avoid deeply nested control flow statements.
                Open

                                            if (!string.IsNullOrEmpty(response))
                                // If added time entry in redmine issue
                                replyText = string.Format(_stringConstant.TimeEnrtyAddSuccessfully, issueId);
                            else
                                // If error in adding time entry in redmine issue
                Severity: Major
                Found in Slack.Automation/Promact.Core.Repository/RedmineRepository/RedmineRepository.cs - About 45 mins to fix

                  Avoid deeply nested control flow statements.
                  Open

                                                  case SlackAction.help:
                                    replyText = _stringConstant.RedmineHelp;
                                    break;
                  Severity: Major
                  Found in Slack.Automation/Promact.Core.Repository/RedmineRepository/RedmineRepository.cs - About 45 mins to fix

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                                    replyText = string.Format(_stringConstant.RedmineStatusErrorMessage,
                    Status.New.ToString(), Status.InProgess.ToString(), Status.Confirmed.ToString(),
                    Status.Resolved.ToString(), Status.Hold.ToString(), Status.Feedback.ToString(),
                    Status.Closed.ToString(), Status.Rejected.ToString());
                    Severity: Major
                    Found in Slack.Automation/Promact.Core.Repository/RedmineRepository/RedmineRepository.cs and 1 other location - About 1 hr to fix
                    Slack.Automation/Promact.Core.Test/RedmineRepositoryTest.cs on lines 191..194

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 110.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                                            else
                            // If TimeEntryActivity is not valid
                            replyText = string.Format(_stringConstant.TimeEntryActivityErrorMessage, TimeEntryActivity.Analysis.ToString(),
                                TimeEntryActivity.Design.ToString(), TimeEntryActivity.Development.ToString(), TimeEntryActivity.Roadblock.ToString(),
                                TimeEntryActivity.Testing.ToString());
                    Severity: Minor
                    Found in Slack.Automation/Promact.Core.Repository/RedmineRepository/RedmineRepository.cs and 1 other location - About 50 mins to fix
                    Slack.Automation/Promact.Core.Repository/RedmineRepository/RedmineRepository.cs on lines 116..120

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 81.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                                                            else
                                            // If command action is not in format
                                            replyText = string.Format(_stringConstant.ProperRedmineIssueAction, RedmineAction.list.ToString(),
                                                RedmineAction.create.ToString(), RedmineAction.changeassignee.ToString(), RedmineAction.close.ToString(),
                                                RedmineAction.timeentry.ToString());
                    Severity: Minor
                    Found in Slack.Automation/Promact.Core.Repository/RedmineRepository/RedmineRepository.cs and 1 other location - About 50 mins to fix
                    Slack.Automation/Promact.Core.Repository/RedmineRepository/RedmineRepository.cs on lines 532..536

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 81.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                                    replyText = string.Format(_stringConstant.RedmineTrackerErrorMessage,
                    Tracker.Bug.ToString(), Tracker.Feature.ToString(), Tracker.Support.ToString(),
                    Tracker.Tasks.ToString());
                    Severity: Minor
                    Found in Slack.Automation/Promact.Core.Repository/RedmineRepository/RedmineRepository.cs and 1 other location - About 30 mins to fix
                    Slack.Automation/Promact.Core.Test/RedmineRepositoryTest.cs on lines 208..210

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 62.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                                            replyText += string.Format(_stringConstant.RedmineIssueMessageFormat, issue.Project.Name, issue.IssueId,
                            issue.Subject, issue.Status.Name, issue.Priority.Name, issue.Tracker.Name);
                    Severity: Minor
                    Found in Slack.Automation/Promact.Core.Repository/RedmineRepository/RedmineRepository.cs and 1 other location - About 30 mins to fix
                    Slack.Automation/Promact.Core.Test/RedmineRepositoryTest.cs on lines 707..708

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 62.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status