Promact/slack-erp-custom-integration-mvc

View on GitHub
Slack.Automation/Promact.Core.Repository/TaskMailRepository/TaskMailRepository.cs

Summary

Maintainability
F
4 days
Test Coverage

Method QuestionAndAnswerAsync has a Cognitive Complexity of 117 (exceeds 20 allowed). Consider refactoring.
Open

        public async Task<string> QuestionAndAnswerAsync(string answer, string userId)
        {
            // method to get user's details, user's accesstoken, user's task mail details and list or else appropriate message will be send
            var userAndTaskMailDetailsWithAccessToken = await GetUserAndTaskMailDetailsAsync(userId);
            _logger.Info("Task Mail Bot Module, Is task mail question text : " + userAndTaskMailDetailsWithAccessToken.QuestionText);

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method QuestionAndAnswerAsync has 201 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        public async Task<string> QuestionAndAnswerAsync(string answer, string userId)
        {
            // method to get user's details, user's accesstoken, user's task mail details and list or else appropriate message will be send
            var userAndTaskMailDetailsWithAccessToken = await GetUserAndTaskMailDetailsAsync(userId);
            _logger.Info("Task Mail Bot Module, Is task mail question text : " + userAndTaskMailDetailsWithAccessToken.QuestionText);

    File TaskMailRepository.cs has 388 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    ´╗┐using Promact.Core.Repository.OauthCallsRepository;
    using Promact.Erp.DomainModel.Models;
    using System;
    using System.Threading.Tasks;
    using System.Linq;

      Method StartTaskMailAsync has 47 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              public async Task<string> StartTaskMailAsync(string userId)
              {
                  // method to get user's details, user's accesstoken, user's task mail details and list or else appropriate message will be send
                  var userAndTaskMailDetailsWithAccessToken = await GetUserAndTaskMailDetailsAsync(userId);
                  _logger.Info("Task Mail Bot Module, Is task mail question text : " + userAndTaskMailDetailsWithAccessToken.QuestionText);

        Method GetUserAndTaskMailDetailsAsync has 36 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                private async Task<UserAndTaskMailDetailsWithAccessToken> GetUserAndTaskMailDetailsAsync(string slackUserId)
                {
                    UserAndTaskMailDetailsWithAccessToken userAndTaskMailDetailsWithAccessToken = new UserAndTaskMailDetailsWithAccessToken();
                    var user = await _userRepository.FirstOrDefaultAsync(x => x.SlackUserId == slackUserId);
                    if (user != null)

          Avoid deeply nested control flow statements.
          Open

                                              if (answer != null)
                                              {
                                                  // if previous question was comment of task and answer was not null/wrong value then answer will ask next question
                                                  taskDetails.Comment = answer;
                                                  userAndTaskMailDetailsWithAccessToken.QuestionText = nextQuestion.QuestionStatement;

            Avoid deeply nested control flow statements.
            Open

                                                if (sendEmailConfirmationConvertResult)
                                                {
                                                    taskDetails.SendEmailConfirmation = confirmation;
                                                    userAndTaskMailDetailsWithAccessToken.QuestionText = _stringConstant.ThankYou;
                                                    switch (confirmation)

              Avoid deeply nested control flow statements.
              Open

                                                  if (taskMailHourConvertResult)
                                                  {
                                                      decimal totalHourSpented = 0;
                                                      // checking range of hours
                                                      if (hour > 0 && hour <= Convert.ToInt32(_stringConstant.TaskMailMaximumTime))

                Avoid deeply nested control flow statements.
                Open

                                                    if (taskMailStatusConvertResult)
                                                    {
                                                        // if previous question was status of task and it was not null/wrong value then answer will ask next question
                                                        taskDetails.Status = status;
                                                        userAndTaskMailDetailsWithAccessToken.QuestionText = nextQuestion.QuestionStatement;

                  Avoid deeply nested control flow statements.
                  Open

                                                      if (sendEmailConfirmationConvertResult)
                                                      {
                                                          taskDetails.SendEmailConfirmation = confirmation;
                                                          switch (confirmation)
                                                          {

                    Avoid deeply nested control flow statements.
                    Open

                                                        if (answer != null)
                                                        {
                                                            taskDetails.Description = answer;
                                                            userAndTaskMailDetailsWithAccessToken.QuestionText = nextQuestion.QuestionStatement;
                                                            taskDetails.QuestionId = nextQuestion.Id;

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                                                  case QuestionOrder.YourTask:
                                                      {
                                                          // if previous question was description of task and it was not null/wrong vale then answer will ask next question
                                                          if (answer != null)
                                                          {
                      Slack.Automation/Promact.Core.Repository/TaskMailRepository/TaskMailRepository.cs on lines 244..259

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 68.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                                                  case QuestionOrder.Comment:
                                                      {
                                                          if (answer != null)
                                                          {
                                                              // if previous question was comment of task and answer was not null/wrong value then answer will ask next question
                      Slack.Automation/Promact.Core.Repository/TaskMailRepository/TaskMailRepository.cs on lines 154..169

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 68.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      There are no issues that match your filters.

                      Category
                      Status