Showing 326 of 326 total issues
Function mongoStoreFactory
has 663 lines of code (exceeds 25 allowed). Consider refactoring. Open
function mongoStoreFactory(waterline, Promise, Constants, Errors, assert, _) {
var exports = {};
exports.publishRecordByGraphId = function (graphId, event) {
return waterline.graphobjects.needOneMongo(
Function ModelFactory
has 502 lines of code (exceeds 25 allowed). Consider refactoring. Open
function ModelFactory (
pluralize,
Promise,
_,
util,
Function taskProtocolFactory
has 411 lines of code (exceeds 25 allowed). Consider refactoring. Open
function taskProtocolFactory (Promise, assert, Constants, Errors, messenger, _, Result) {
function TaskProtocol() {
}
TaskProtocol.prototype.run = function (domain, data) {
Function eventsProtocolFactory
has 344 lines of code (exceeds 25 allowed). Consider refactoring. Open
function eventsProtocolFactory (
Constants,
_,
messenger,
hook,
Function constantsFactory
has 325 lines of code (exceeds 25 allowed). Consider refactoring. Open
function constantsFactory (path) {
var constants = Object.freeze({
WorkingDirectory: process.cwd(),
Name: process.cwd().split(path.sep).reverse()[0],
Host: require('os').hostname().split(/\./)[0],
Function setupDiHelper
has a Cognitive Complexity of 81 (exceeds 5 allowed). Consider refactoring. Open
function setupDiHelper(di, defaultDirectory) {
var resolve = require('resolve'),
_ = require('lodash'),
glob = require('glob');
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
File mongo.js
has 676 lines of code (exceeds 250 allowed). Consider refactoring. Open
// Copyright © 2015-2017 Dell Inc. or its subsidiaries. All Rights Reserved.
'use strict';
module.exports = mongoStoreFactory;
mongoStoreFactory.$provide = 'TaskGraph.Stores.Mongo';
Function lookupServiceFactory
has 297 lines of code (exceeds 25 allowed). Consider refactoring. Open
function lookupServiceFactory(
Promise,
waterline,
configuration,
assert,
Function taskGraphRunnerProtocolFactory
has 282 lines of code (exceeds 25 allowed). Consider refactoring. Open
function taskGraphRunnerProtocolFactory (
Promise,
messenger,
Constants,
assert,
Function setupDiHelper
has 273 lines of code (exceeds 25 allowed). Consider refactoring. Open
function setupDiHelper(di, defaultDirectory) {
var resolve = require('resolve'),
_ = require('lodash'),
glob = require('glob');
Function ModelFactory
has a Cognitive Complexity of 64 (exceeds 5 allowed). Consider refactoring. Open
function ModelFactory (
pluralize,
Promise,
_,
util,
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function messengerFactory
has 239 lines of code (exceeds 25 allowed). Consider refactoring. Open
function messengerFactory(
Constants,
Promise,
assert,
Connection,
Function dhcpProtocolFactory
has 239 lines of code (exceeds 25 allowed). Consider refactoring. Open
function dhcpProtocolFactory (
Promise,
Constants,
messenger,
assert,
Function WorkItemModelFactory
has 228 lines of code (exceeds 25 allowed). Consider refactoring. Open
function WorkItemModelFactory (
Model,
_,
Promise,
assert,
File model.js
has 528 lines of code (exceeds 250 allowed). Consider refactoring. Open
// Copyright 2015, EMC, Inc.
'use strict';
module.exports = ModelFactory;
Function dbRenderableContentServiceFactory
has 209 lines of code (exceeds 25 allowed). Consider refactoring. Open
function dbRenderableContentServiceFactory(
FileLoader,
Constants,
Promise,
_,
Function jsonSchemaValidatorFactory
has 183 lines of code (exceeds 25 allowed). Consider refactoring. Open
function jsonSchemaValidatorFactory(
Ajv,
assert,
nodeFs,
path,
Similar blocks of code found in 3 locations. Consider refactoring. Open
TaskProtocol.prototype.subscribeRequestProperties = function (identifier, callback) {
assert.ok(identifier);
assert.func(callback);
return messenger.subscribe(
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 177.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 3 locations. Consider refactoring. Open
TaskProtocol.prototype.subscribeRequestCommands = function (identifier, callback) {
assert.ok(identifier);
assert.func(callback);
return messenger.subscribe(
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 177.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 3 locations. Consider refactoring. Open
TaskProtocol.prototype.subscribeRequestProfile = function (identifier, callback) {
assert.ok(identifier);
assert.func(callback);
return messenger.subscribe(
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 177.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76