Sign upLogin

RackHD/on-http

View on GitHub
Star

Showing 440 of 440 total issues

File systems.js has 2035 lines of code (exceeds 250 allowed). Consider refactoring.
Open

// Copyright 2016, EMC, Inc.

'use strict';

var injector = require('../../../index.js').injector;
Severity: Major
Found in lib/api/redfish-1.0/systems.js - About 5 days to fix

    Function nodeApiServiceFactory has 544 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function nodeApiServiceFactory(
    workflowApiService,
    waterline,
    Errors,
    Logger,
    Severity: Major
    Found in lib/services/nodes-api-service.js - About 2 days to fix

      Function skuPackServiceFactory has 516 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function skuPackServiceFactory(
    _,
    waterline,
    Logger,
    FileLoader,
      Severity: Major
      Found in lib/services/sku-pack-service.js - About 2 days to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                } else if (result.vendor === 'Cisco') {
            return dataFactory(chassisId, 'ucsPower')
            .then(function(powerData) {
                var ucsPowerThermalData = powerData['ucs.powerthermal'];
                var ucsPsuData = powerData['ucs.psu'];
        Severity: Major
        Found in lib/api/redfish-1.0/chassis.js and 1 other location - About 1 day to fix
        lib/api/redfish-1.0/chassis.js on lines 361..424

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 333.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                } else if (result.vendor === 'Cisco') {
            return dataFactory(chassisId, 'ucsThermal')
            .then(function(thermalData) {
                var ucsPowerThermalData = thermalData['ucs.powerthermal'];
                var ucsFanData = thermalData['ucs.fan'];
        Severity: Major
        Found in lib/api/redfish-1.0/chassis.js and 1 other location - About 1 day to fix
        lib/api/redfish-1.0/chassis.js on lines 448..506

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 333.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function swaggerFactory has 328 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function swaggerFactory(
    Promise,
    Errors,
    _,
    injector,
        Severity: Major
        Found in lib/services/swagger-api-service.js - About 1 day to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              return waterline.ibms.needByIdentifier(ibmId)
        .then(function(oldIbm) {
            /* Get nodes that need to publish events */
            if (oldIbm.node && !values.nodeId) {
                return Promise.all([waterline.nodes.getNodeById(oldIbm.node)]);
          Severity: Major
          Found in lib/api/2.0/ibms.js and 1 other location - About 1 day to fix
          lib/services/obm-api-service.js on lines 259..290

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 282.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  return waterline.obms.needByIdentifier(obmId)
        .then(function(oldObm) {
            /* Get nodes that need to publish events */
            if (oldObm.node && !values.nodeId) {
                return Promise.all([waterline.nodes.getNodeById(oldObm.node)]);
          Severity: Major
          Found in lib/services/obm-api-service.js and 1 other location - About 1 day to fix
          lib/api/2.0/ibms.js on lines 36..67

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 282.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                  if (result.vendor === 'Dell') {
            var graph = {
                name: "Graph.Dell.Wsman.Reset.Components",
                options: {
                    defaults: {
          Severity: Major
          Found in lib/api/redfish-1.0/systems.js and 2 other locations - About 1 day to fix
          lib/api/redfish-1.0/systems.js on lines 438..493
          lib/api/redfish-1.0/systems.js on lines 525..598

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 263.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                  if (result.vendor === 'Dell') {
            var results = { name: "Graph.Dell.Wsman.UpdateSystemComponents", options: {} };

            return dataFactory(identifier, 'DeviceSummary').then(function(summary) {
          Severity: Major
          Found in lib/api/redfish-1.0/systems.js and 2 other locations - About 1 day to fix
          lib/api/redfish-1.0/systems.js on lines 525..598
          lib/api/redfish-1.0/systems.js on lines 619..657

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 263.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                  if (result.vendor === 'Dell') {

            var results = { name: "Graph.Dell.Wsman.UpdateSystemComponents", options: {} };
            return mktemp
                .createFile('/nfs/XXXXXX.xml')
          Severity: Major
          Found in lib/api/redfish-1.0/systems.js and 2 other locations - About 1 day to fix
          lib/api/redfish-1.0/systems.js on lines 438..493
          lib/api/redfish-1.0/systems.js on lines 619..657

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 263.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 3 locations. Consider refactoring.
          Open

                  if(result.vendor === 'Dell'){
            return Promise.resolve(dataFactory(identifier, 'hardware'))
            .then(function(hardware) {
                var driveIndices = [];
                var i;
          Severity: Major
          Found in lib/api/redfish-1.0/systems.js and 2 other locations - About 1 day to fix
          lib/api/redfish-1.0/systems.js on lines 1997..2029
          lib/api/redfish-1.0/systems.js on lines 2173..2214

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 260.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 3 locations. Consider refactoring.
          Open

                  if(result.vendor === 'Dell'){
            return Promise.resolve(dataFactory(identifier, 'hardware'))
            .then(function(hardware) {
                graphOptions.defaults.driveId = hardware.data.storage.physicalDisks[driveIndex].fqdd;
                graphOptions.defaults.ipAddress = hardware.data.id;
          Severity: Major
          Found in lib/api/redfish-1.0/systems.js and 2 other locations - About 1 day to fix
          lib/api/redfish-1.0/systems.js on lines 1997..2029
          lib/api/redfish-1.0/systems.js on lines 2060..2138

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 260.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 3 locations. Consider refactoring.
          Open

                  if(result.vendor === 'Dell'){
            return Promise.resolve(dataFactory(identifier, 'hardware'))
            .then(function(hardware) {
                graphOptions.defaults.volumeId = hardware.data.storage.virtualDisks[volumeIndex].fqdd;
                graphOptions.defaults.ipAddress = hardware.data.id;
          Severity: Major
          Found in lib/api/redfish-1.0/systems.js and 2 other locations - About 1 day to fix
          lib/api/redfish-1.0/systems.js on lines 2060..2138
          lib/api/redfish-1.0/systems.js on lines 2173..2214

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 260.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function nodeApiServiceFactory has a Cognitive Complexity of 70 (exceeds 5 allowed). Consider refactoring.
          Open

          function nodeApiServiceFactory(
    workflowApiService,
    waterline,
    Errors,
    Logger,
          Severity: Minor
          Found in lib/services/nodes-api-service.js - About 1 day to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function httpServiceFactory has 276 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function httpServiceFactory(
    eventsProtocol,
    configuration,
    lookupService,
    swagger,
          Severity: Major
          Found in lib/services/http-service.js - About 1 day to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            var listDCIMCoolingTypeCollection = controller(function (req, res) {
    var options = redfish.makeOptions(req, res);
    options.type = req.swagger.params.type.value;
    options.domain = req.swagger.params.domain.value;
            Severity: Major
            Found in lib/api/redfish-1.0/dcimcooling.js and 1 other location - About 1 day to fix
            lib/api/redfish-1.0/dcimpower.js on lines 54..75

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 250.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            var listDCIMPowerTypeCollection = controller(function (req, res) {
    var options = redfish.makeOptions(req, res);
    options.type = req.swagger.params.type.value;
    options.domain = req.swagger.params.domain.value;
            Severity: Major
            Found in lib/api/redfish-1.0/dcimpower.js and 1 other location - About 1 day to fix
            lib/api/redfish-1.0/dcimcooling.js on lines 52..71

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 250.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Function NotificationApiServiceFactory has 263 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            function NotificationApiServiceFactory(
    eventsProtocol,
    Logger,
    waterline,
    Errors,
            Severity: Major
            Found in lib/services/notification-api-service.js - About 1 day to fix

              Function obmApiServiceFactory has 255 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              function obmApiServiceFactory(
    waterline,
    Logger,
    eventsProtocol,
    Promise,
              Severity: Major
              Found in lib/services/obm-api-service.js - About 1 day to fix
                Severity
                Category
                Status
                Source
                Language