SAREhub/PHP_Client

View on GitHub
src/SAREhub/Client/Amqp/EnvAmqpConnectionOptionsProvider.php

Summary

Maintainability
A
0 mins
Test Coverage

Avoid using static access to class '\SAREhub\Commons\Misc\EnvironmentHelper' in method 'get'.
Open

        $env = EnvironmentHelper::getVars($this->envSchema, $this->envVarPrefix);

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

There must be one blank line after the namespace declaration
Open

namespace SAREhub\Client\Amqp;

The closing parenthesis and the opening brace of a multi-line function declaration must be on the same line
Open

    {

Expected 1 newline at end of file; 0 found
Open

}

There are no issues that match your filters.

Category
Status