Sign upLogin

SAREhub/php_component_worker

View on GitHub
Star
cli/test_worker/testWorkerRunner.php

Summary

Maintainability
A
1 hr
Test Coverage

Avoid unused parameters such as '$replyCallback'.
Open

    protected function doCommand(Command $command, callable $replyCallback) {
Severity: Minor
Found in cli/test_worker/testWorkerRunner.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Similar blocks of code found in 2 locations. Consider refactoring.
Open

class TestWorker extends BasicWorker {
    
    protected function doStart() {
        $this->logInfo('doStart');
    }
Severity: Major
Found in cli/test_worker/testWorkerRunner.php and 1 other location - About 1 hr to fix
examples/WorkerManager/workerScript.php on lines 18..40

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 118.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status