SAREhub/php_component_worker

View on GitHub
src/SAREhub/Component/Worker/Command/ZmqCommandOutput.php

Summary

Maintainability
A
0 mins
Test Coverage

The method send has a boolean flag argument $wait, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function send($topic, Command $command, $wait = false) {

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

There are no issues that match your filters.

Category
Status