Sign upLogin

SDPepe/AppArt

View on GitHub
Star
app/src/main/java/ch/epfl/sdp/appart/AdActivity.java

Summary

Maintainability
A
3 hrs
Test Coverage
C
79%

File AdActivity.java has 342 lines of code (exceeds 250 allowed). Consider refactoring.
Wontfix

package ch.epfl.sdp.appart;

import android.content.Context;
import android.content.Intent;
import android.graphics.Bitmap;
Severity: Minor
Found in app/src/main/java/ch/epfl/sdp/appart/AdActivity.java - About 4 hrs to fix

    AdActivity has 26 methods (exceeds 20 allowed). Consider refactoring.
    Wontfix

    @AndroidEntryPoint
public class AdActivity extends ToolbarActivity {

    @Inject
    DatabaseService database;
    Severity: Minor
    Found in app/src/main/java/ch/epfl/sdp/appart/AdActivity.java - About 3 hrs to fix

      Method saveFavorite has 43 lines of code (exceeds 25 allowed). Consider refactoring.
      Wontfix

          private void saveFavorite(CompletableFuture<Boolean> result, User user) {
        boolean alreadyAdded = user.getFavoritesIds().contains(adId);
        CompletableFuture<List<Card>> futureCards = database.getCards();
        CompletableFuture<Card> futureLocalUpdate;
        if (alreadyAdded) {
      Severity: Minor
      Found in app/src/main/java/ch/epfl/sdp/appart/AdActivity.java - About 1 hr to fix

        Method onCreate has 35 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_announce);
        Severity: Minor
        Found in app/src/main/java/ch/epfl/sdp/appart/AdActivity.java - About 1 hr to fix

          Method updatePhotos has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              private void updatePhotos(Pair<List<String>, Boolean> referencesAndIsLocal) {
        LinearLayout horizontalLayout =
                findViewById(R.id.horizontal_children_Ad_linearLayout);
        horizontalLayout.removeAllViews();
        List<String> references = referencesAndIsLocal.first;
          Severity: Minor
          Found in app/src/main/java/ch/epfl/sdp/appart/AdActivity.java - About 1 hr to fix

            Avoid too many return statements within this method.
            Open

                                return null;
            Severity: Major
            Found in app/src/main/java/ch/epfl/sdp/appart/AdActivity.java - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                          return null;
              Severity: Major
              Found in app/src/main/java/ch/epfl/sdp/appart/AdActivity.java - About 30 mins to fix

                There are no issues that match your filters.

                Category
                Status