Sign upLogin

SDPepe/AppArt

View on GitHub
Star
app/src/main/java/ch/epfl/sdp/appart/AdCreationActivity.java

Summary

Maintainability
A
0 mins
Test Coverage
B
82%

Method onActivityResult has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Wontfix

    @Override
    protected void onActivityResult(int requestCode, int resultCode, @Nullable Intent data) {
        super.onActivityResult(requestCode, resultCode, data);
        if (requestCode == 1) {
            if (resultCode == RESULT_OK) {
Severity: Minor
Found in app/src/main/java/ch/epfl/sdp/appart/AdCreationActivity.java - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method createAd has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Wontfix

    private void createAd() {
        // if some fields are not filled, show snackbar
        if (!everyFieldFilled()) {
            Snackbar.make(findViewById(R.id.horizontal_AdCreation_scrollView),
                    getResources().getText(R.string.snackbarNotFilled_AdCreation),
Severity: Minor
Found in app/src/main/java/ch/epfl/sdp/appart/AdCreationActivity.java - About 1 hr to fix

    Consider simplifying this complex logical expression.
    Invalid

            if (stringIsInvalid(getContentOfEditText(R.id.title_AdCreation_editText)) ||
                stringIsInvalid(getContentOfEditText(R.id.street_AdCreation_editText)) ||
                stringIsInvalid(getContentOfEditText(R.id.number_AdCreation_ediText)) ||
                stringIsInvalid(getContentOfEditText(R.id.npa_AdCreation_editText)) ||
                stringIsInvalid(getContentOfEditText(R.id.city_AdCreation_editText)) ||
    Severity: Major
    Found in app/src/main/java/ch/epfl/sdp/appart/AdCreationActivity.java - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status