Sign upLogin

SDPepe/AppArt

View on GitHub
Star
app/src/main/java/ch/epfl/sdp/appart/database/local/LocalDatabase.java

Summary

Maintainability
A
0 mins
Test Coverage
B
80%

File LocalDatabase.java has 304 lines of code (exceeds 250 allowed). Consider refactoring.
Wontfix

package ch.epfl.sdp.appart.database.local;

import android.graphics.Bitmap;

import java.io.File;
Severity: Minor
Found in app/src/main/java/ch/epfl/sdp/appart/database/local/LocalDatabase.java - About 3 hrs to fix

    Method writeCompleteAd has 50 lines of code (exceeds 25 allowed). Consider refactoring.
    Wontfix

        public CompletableFuture<Void> writeCompleteAd(String adId,
                                                   String cardId, Ad ad,
                                                   User user,
                                                   List<Bitmap> adPhotos,
                                                   List<Bitmap> panoramas,
    Severity: Minor
    Found in app/src/main/java/ch/epfl/sdp/appart/database/local/LocalDatabase.java - About 2 hrs to fix

      Method setCurrentUser has 44 lines of code (exceeds 25 allowed). Consider refactoring.
      Wontfix

          public CompletableFuture<Void> setCurrentUser(User currentUser,
                                                  Bitmap profilePic) {
        this.currentUser = currentUser;

        CompletableFuture<Void> futureSuccess = new CompletableFuture<>();
      Severity: Minor
      Found in app/src/main/java/ch/epfl/sdp/appart/database/local/LocalDatabase.java - About 1 hr to fix

        Method removeCard has 34 lines of code (exceeds 25 allowed). Consider refactoring.
        Wontfix

            public void removeCard(String cardId) {
        // if there is no currentUser, then card is no present
        User currentUser;
        try {
            currentUser = getCurrentUser();
        Severity: Minor
        Found in app/src/main/java/ch/epfl/sdp/appart/database/local/LocalDatabase.java - About 1 hr to fix

          Method getFromMemory has 31 lines of code (exceeds 25 allowed). Consider refactoring.
          Wontfix

              private <T> CompletableFuture<T> getFromMemory(Supplier<T> returnFunc) {
        if (this.firstLoad) {
            return CompletableFuture.completedFuture(returnFunc.get());
        }
        //TODO: I don't know why I have a threading issue here, this needs to
          Severity: Minor
          Found in app/src/main/java/ch/epfl/sdp/appart/database/local/LocalDatabase.java - About 1 hr to fix

            Method writeCompleteAd has 7 arguments (exceeds 4 allowed). Consider refactoring.
            Wontfix

                public CompletableFuture<Void> writeCompleteAd(String adId,
                                                   String cardId, Ad ad,
                                                   User user,
                                                   List<Bitmap> adPhotos,
                                                   List<Bitmap> panoramas,
            Severity: Major
            Found in app/src/main/java/ch/epfl/sdp/appart/database/local/LocalDatabase.java - About 50 mins to fix

              Method checkInfo has 6 arguments (exceeds 4 allowed). Consider refactoring.
              Wontfix

                  private static void checkInfo(String adId, String cardId, Ad ad,
                                  User user, List<Bitmap> adPhotos,
                                  List<Bitmap> panoramas) {
              Severity: Minor
              Found in app/src/main/java/ch/epfl/sdp/appart/database/local/LocalDatabase.java - About 45 mins to fix

                Consider simplifying this complex logical expression.
                Wontfix

                        if (adId == null || cardId == null || ad == null || user == null || adPhotos == null || panoramas == null)
            throw new IllegalArgumentException();
                Severity: Major
                Found in app/src/main/java/ch/epfl/sdp/appart/database/local/LocalDatabase.java - About 40 mins to fix

                  Method setCurrentUser has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                  Wontfix

                      public CompletableFuture<Void> setCurrentUser(User currentUser,
                                                  Bitmap profilePic) {
        this.currentUser = currentUser;

        CompletableFuture<Void> futureSuccess = new CompletableFuture<>();
                  Severity: Minor
                  Found in app/src/main/java/ch/epfl/sdp/appart/database/local/LocalDatabase.java - About 35 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method removeCard has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                  Wontfix

                      public void removeCard(String cardId) {
        // if there is no currentUser, then card is no present
        User currentUser;
        try {
            currentUser = getCurrentUser();
                  Severity: Minor
                  Found in app/src/main/java/ch/epfl/sdp/appart/database/local/LocalDatabase.java - About 35 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Avoid too many return statements within this method.
                  Wontfix

                          return futureSuccess;
                  Severity: Major
                  Found in app/src/main/java/ch/epfl/sdp/appart/database/local/LocalDatabase.java - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Wontfix

                            return futureSuccess;
                    Severity: Major
                    Found in app/src/main/java/ch/epfl/sdp/appart/database/local/LocalDatabase.java - About 30 mins to fix

                      Method syncWithMemory has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                      Wontfix

                          private void syncWithMemory(String adID, Ad localAd, Card localCard,
                                User localUser) {
        if (this.firstLoad) {
            if (!this.idsToAd.containsKey(adID)) {
                this.idsToAd.put(adID, localAd);
                      Severity: Minor
                      Found in app/src/main/java/ch/epfl/sdp/appart/database/local/LocalDatabase.java - About 25 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Identical blocks of code found in 2 locations. Consider refactoring.
                      Invalid

                              if (adId == null || cardId == null || ad == null || user == null || adPhotos == null || panoramas == null)
                      Severity: Minor
                      Found in app/src/main/java/ch/epfl/sdp/appart/database/local/LocalDatabase.java and 1 other location - About 35 mins to fix
                      app/src/main/java/ch/epfl/sdp/appart/ad/Ad.java on lines 46..47

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 46.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      There are no issues that match your filters.

                      Category
                      Status