SU-SWS/decanter

View on GitHub

Showing 9 of 67 total issues

Function onKeydown has a Cognitive Complexity of 44 (exceeds 10 allowed). Consider refactoring.
Open

  onKeydown(event, target) {
    const theKey = event.key || event.keyCode;

    // Handler for the space and enter key.
    if (isSpace(theKey) || isEnter(theKey)) {
Severity: Minor
Found in core/src/js/components/main-nav/NavItem.js - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function onKeydown has 85 lines of code (exceeds 40 allowed). Consider refactoring.
Open

  onKeydown(event, target) {
    const theKey = event.key || event.keyCode;

    // Handler for the space and enter key.
    if (isSpace(theKey) || isEnter(theKey)) {
Severity: Major
Found in core/src/js/components/main-nav/NavItem.js - About 2 hrs to fix

    Function fetch has 51 lines of code (exceeds 40 allowed). Consider refactoring.
    Open

      fetch() {
        try {
          switch (this.what) {
            case 'first':
              return this.item.parentNode.firstElementChild.firstChild;
    Severity: Major
    Found in core/src/js/components/nav/ElementFetcher.js - About 1 hr to fix

      Function onKeydown has a Cognitive Complexity of 16 (exceeds 10 allowed). Consider refactoring.
      Open

        onKeydown(event, target) {
          const theKey = event.key || event.keyCode;
      
          if (isEsc(theKey)) {
            if (this.isTopNav()) {
      Severity: Minor
      Found in core/src/js/components/main-nav/Nav.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid deeply nested control flow statements.
      Open

              if (this.isSubNavItem()) {
                // Close the subnav and put the focus on the trigger.
                this.closeSubNav(true);
              }
      Severity: Major
      Found in core/src/js/components/main-nav/NavItem.js - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                if (this.nav.isSubNav()) {
                  this.closeSubNav();
                  let parent = this.nav.getParentNav();
                  // Focus on the previous item in the parent nav.
                  parent.focusOn('prev', this.nav.elem);
        Severity: Major
        Found in core/src/js/components/main-nav/NavItem.js - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                if (this.nav.isDesktopNav()) {
                  if (this.nav.isSubNav()) {
                    this.closeSubNav();
                    let parent = this.nav.getParentNav();
                    // Focus on the next item in the parent nav.
          Severity: Major
          Found in core/src/js/components/main-nav/NavItem.js - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                else if (isHome(theKey)) {
                  this.nav.focusOn('first');
                }
                // Handler for the end key.
                else if (isEnd(theKey)) {
            Severity: Major
            Found in core/src/js/components/main-nav/NavItem.js - About 45 mins to fix

              Function focusOn has a Cognitive Complexity of 11 (exceeds 10 allowed). Consider refactoring.
              Open

                focusOn(link, currentItem = null) {
                  let currentIndex = null;
                  let lastIndex = null;
                  if (currentItem) {
                    currentIndex = this.items.indexOf(currentItem);
              Severity: Minor
              Found in core/src/js/components/main-nav/Nav.js - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Severity
              Category
              Status
              Source
              Language