SU-SWS/react_paragraphs

View on GitHub

Showing 113 of 216 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  const toDatetimeUtc = (timestamp) => {
    const date = new Date(timestamp),
      ten = function (i) {
        return (i < 10 ? '0' : '') + i;
      },
Severity: Major
Found in js/src/Components/Widgets/DateWidget.js and 1 other location - About 7 hrs to fix
js/src/Components/Widgets/DateWidget.js on lines 7..20

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 191.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  const toDatetimeLocal = (timestamp) => {
    const date = new Date(timestamp),
      ten = function (i) {
        return (i < 10 ? '0' : '') + i;
      },
Severity: Major
Found in js/src/Components/Widgets/DateWidget.js and 1 other location - About 7 hrs to fix
js/src/Components/Widgets/DateWidget.js on lines 22..35

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 191.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function LinkWidget has a Cognitive Complexity of 51 (exceeds 10 allowed). Consider refactoring.
Open

export const LinkWidget = ({fieldId, defaultValue, onFieldChange, settings}) => {
  let timeout;
  let initialCondition = defaultValue;

  try {
Severity: Minor
Found in js/src/Components/Widgets/LinkWidget.js - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid excessively long variable names like $entity_type_definition. Keep variable name length under 20.
Open

    $entity_type_definition = $this->entityTypeManager->getDefinition($entity_type_id);

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long variable names like $reactFieldsPluginManager. Keep variable name length under 20.
Open

  protected $reactFieldsPluginManager;

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Function render has 51 lines of code (exceeds 40 allowed). Consider refactoring.
Open

  render() {
    return (
      <FormGroup ref={this.widgetRef}>
        {this.getSummaryInput()}

Severity: Major
Found in js/src/Components/Widgets/CkeditorWidget.js - About 1 hr to fix

    Avoid using undefined variables such as '$row' which will lead to PHP notices.
    Open

        $row['id'] = $entity->id();
    Severity: Minor
    Found in src/ParagraphsRowTypeListBuilder.php by phpmd

    UndefinedVariable

    Since: 2.8.0

    Detects when a variable is used that has not been defined before.

    Example

    class Foo
    {
        private function bar()
        {
            // $message is undefined
            echo $message;
        }
    }

    Source https://phpmd.org/rules/cleancode.html#undefinedvariable

    Avoid using undefined variables such as '$header' which will lead to PHP notices.
    Open

        return $header + parent::buildHeader();
    Severity: Minor
    Found in src/ParagraphsRowTypeListBuilder.php by phpmd

    UndefinedVariable

    Since: 2.8.0

    Detects when a variable is used that has not been defined before.

    Example

    class Foo
    {
        private function bar()
        {
            // $message is undefined
            echo $message;
        }
    }

    Source https://phpmd.org/rules/cleancode.html#undefinedvariable

    Avoid using undefined variables such as '$header' which will lead to PHP notices.
    Open

        $header['label'] = $this->t('Paragraphs Row type');
    Severity: Minor
    Found in src/ParagraphsRowTypeListBuilder.php by phpmd

    UndefinedVariable

    Since: 2.8.0

    Detects when a variable is used that has not been defined before.

    Example

    class Foo
    {
        private function bar()
        {
            // $message is undefined
            echo $message;
        }
    }

    Source https://phpmd.org/rules/cleancode.html#undefinedvariable

    Avoid using undefined variables such as '$header' which will lead to PHP notices.
    Open

        $header['id'] = $this->t('Machine name');
    Severity: Minor
    Found in src/ParagraphsRowTypeListBuilder.php by phpmd

    UndefinedVariable

    Since: 2.8.0

    Detects when a variable is used that has not been defined before.

    Example

    class Foo
    {
        private function bar()
        {
            // $message is undefined
            echo $message;
        }
    }

    Source https://phpmd.org/rules/cleancode.html#undefinedvariable

    Avoid using undefined variables such as '$row' which will lead to PHP notices.
    Open

        $row['label'] = $entity->label();
    Severity: Minor
    Found in src/ParagraphsRowTypeListBuilder.php by phpmd

    UndefinedVariable

    Since: 2.8.0

    Detects when a variable is used that has not been defined before.

    Example

    class Foo
    {
        private function bar()
        {
            // $message is undefined
            echo $message;
        }
    }

    Source https://phpmd.org/rules/cleancode.html#undefinedvariable

    Avoid using undefined variables such as '$row' which will lead to PHP notices.
    Open

        return $row + parent::buildRow($entity);
    Severity: Minor
    Found in src/ParagraphsRowTypeListBuilder.php by phpmd

    UndefinedVariable

    Since: 2.8.0

    Detects when a variable is used that has not been defined before.

    Example

    class Foo
    {
        private function bar()
        {
            // $message is undefined
            echo $message;
        }
    }

    Source https://phpmd.org/rules/cleancode.html#undefinedvariable

    Function DateWidget has a Cognitive Complexity of 15 (exceeds 10 allowed). Consider refactoring.
    Open

    export const DateWidget = ({fieldId, defaultValue, onFieldChange, settings}) => {
    
      const toDatetimeLocal = (timestamp) => {
        const date = new Date(timestamp),
          ten = function (i) {
    Severity: Minor
    Found in js/src/Components/Widgets/DateWidget.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Doc comment short description must start with a capital letter
    Open

       * {@inheritDoc}

    Doc comment short description must end with a full stop
    Open

       * {@inheritDoc}

    Doc comment short description must start with a capital letter
    Open

       * {@inheritDoc}

    Doc comment short description must end with a full stop
    Open

       * {@inheritDoc}

    Doc comment short description must start with a capital letter
    Open

       * {@inheritDoc}

    Doc comment short description must end with a full stop
    Open

       * {@inheritDoc}

    Doc comment short description must end with a full stop
    Open

     * Class ReactParagraphsFieldsBase
    Severity
    Category
    Status
    Source
    Language