Sign upLogin

SU-SWS/stanford_publication

View on GitHub
Star
src/CitationViewBuilder.php

Summary

Maintainability
A
0 mins
Test Coverage
A
100%

Avoid assigning values to variables in if clauses and the like (line '24', column '31').
Open

  public function build(array $build) {
    // This assumes the view mode name matches the constant name in the
    // interface.
    $constant = CitationInterface::class . '::' . strtoupper($build['#view_mode']);
Severity: Minor
Found in src/CitationViewBuilder.php by phpmd

IfStatementAssignment

Since: 2.7.0

Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

Example

class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

Invalid offset 0 of array type array{#title:}
Invalid

      $build['su_year'][0]['#markup'] = trim("$date, " . $build['su_year'][0]['#markup'], ', ');
Severity: Minor
Found in src/CitationViewBuilder.php by phan

Doc comment short description must end with a full stop
Invalid

   * {@inheritDoc}
Severity: Minor
Found in src/CitationViewBuilder.php by phpcodesniffer

Doc comment short description must start with a capital letter
Invalid

   * {@inheritDoc}
Severity: Minor
Found in src/CitationViewBuilder.php by phpcodesniffer

There are no issues that match your filters.

Category
Status