Soyhuce/l5-repository

View on GitHub
src/Prettus/Repository/Criteria/RequestCriteria.php

Summary

Maintainability
C
1 day
Test Coverage

Method apply has 103 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function apply($model, RepositoryInterface $repository)
    {
        $fieldsSearchable = $repository->getFieldsSearchable();
        $search = $this->request->get(config('repository.criteria.params.search', 'search'), null);
        $searchFields = $this->request->get(config('repository.criteria.params.searchFields', 'searchFields'), null);
Severity: Major
Found in src/Prettus/Repository/Criteria/RequestCriteria.php - About 4 hrs to fix

    Function parserFieldsSearch has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function parserFieldsSearch(array $fields = [], array $searchFields = null)
        {
            if (!is_null($searchFields) && count($searchFields)) {
                $acceptedConditions = config(
                    'repository.criteria.acceptedConditions',
    Severity: Minor
    Found in src/Prettus/Repository/Criteria/RequestCriteria.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function apply has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
    Open

        public function apply($model, RepositoryInterface $repository)
        {
            $fieldsSearchable = $repository->getFieldsSearchable();
            $search = $this->request->get(config('repository.criteria.params.search', 'search'), null);
            $searchFields = $this->request->get(config('repository.criteria.params.searchFields', 'searchFields'), null);
    Severity: Minor
    Found in src/Prettus/Repository/Criteria/RequestCriteria.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method parserFieldsSearch has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function parserFieldsSearch(array $fields = [], array $searchFields = null)
        {
            if (!is_null($searchFields) && count($searchFields)) {
                $acceptedConditions = config(
                    'repository.criteria.acceptedConditions',
    Severity: Minor
    Found in src/Prettus/Repository/Criteria/RequestCriteria.php - About 1 hr to fix

      Function parserSearchValue has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function parserSearchValue($search)
          {
      
              if (stripos($search, $this->valueDelimiter) || stripos($search, ':')) {
                  $values = explode($this->valueDelimiter, $search);
      Severity: Minor
      Found in src/Prettus/Repository/Criteria/RequestCriteria.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function parserSearchData has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function parserSearchData($search)
          {
              $searchData = [];
      
              if (stripos($search, ':')) {
      Severity: Minor
      Found in src/Prettus/Repository/Criteria/RequestCriteria.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status