Sign upLogin

SpeciesFileGroup/taxonworks

View on GitHub
Star
app/controllers/concerns/token_authentication.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method project_token_authenticate has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

  def project_token_authenticate
    t = params[:project_token]
    h = request.headers['Project token']

    unless t
Severity: Minor
Found in app/controllers/concerns/token_authentication.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Use find_by instead of dynamic find_by_api_access_token.
Open

    @sessions_current_user = User.find_by_api_access_token(t) if t
Severity: Minor
Found in app/controllers/concerns/token_authentication.rb by rubocop

This cop checks dynamic find_by_* methods. Use find_by instead of dynamic method. See. https://github.com/rubocop-hq/rails-style-guide#find_by

Example:

# bad
User.find_by_name(name)

# bad
User.find_by_name_and_email(name)

# bad
User.find_by_email!(name)

# good
User.find_by(name: name)

# good
User.find_by(name: name, email: email)

# good
User.find_by!(email: email)

Use find_by instead of dynamic find_by_api_access_token.
Open

    @sessions_current_project = Project.find_by_api_access_token(t) if t
Severity: Minor
Found in app/controllers/concerns/token_authentication.rb by rubocop

This cop checks dynamic find_by_* methods. Use find_by instead of dynamic method. See. https://github.com/rubocop-hq/rails-style-guide#find_by

Example:

# bad
User.find_by_name(name)

# bad
User.find_by_name_and_email(name)

# bad
User.find_by_email!(name)

# good
User.find_by(name: name)

# good
User.find_by(name: name, email: email)

# good
User.find_by!(email: email)

There are no issues that match your filters.

Category
Status