Sign upLogin

SpeciesFileGroup/taxonworks

View on GitHub
Star
app/controllers/tasks/collecting_events/parse/stepwise/dates_controller.rb

Summary

Maintainability
C
1 day
Test Coverage

Possible SQL injection
Open

      selected_items = CollectingEvent.where(where_clause)
Severity: Minor
Found in app/controllers/tasks/collecting_events/parse/stepwise/dates_controller.rb by brakeman

Injection is #1 on the 2013 OWASP Top Ten web security risks. SQL injection is when a user is able to manipulate a value which is used unsafely inside a SQL query. This can lead to data leaks, data loss, elevation of privilege, and other unpleasant outcomes.

Brakeman focuses on ActiveRecord methods dealing with building SQL statements.

A basic (Rails 2.x) example looks like this:

User.first(:conditions => "username = '#{params[:username]}'")

Brakeman would produce a warning like this:

Possible SQL injection near line 30: User.first(:conditions => ("username = '#{params[:username]}'"))

The safe way to do this query is to use a parameterized query:

User.first(:conditions => ["username = ?", params[:username]])

Brakeman also understands the new Rails 3.x way of doing things (and local variables and concatenation):

username = params[:user][:name].downcase
password = params[:user][:password]

User.first.where("username = '" + username + "' AND password = '" + password + "'")

This results in this kind of warning:

Possible SQL injection near line 37:
User.first.where((((("username = '" + params[:user][:name].downcase) + "' AND password = '") + params[:user][:password]) + "'"))

See the Ruby Security Guide for more information and Rails-SQLi.org for many examples of SQL injection in Rails.

Possible SQL injection
Open

        .where(where_clause).distinct
Severity: Minor
Found in app/controllers/tasks/collecting_events/parse/stepwise/dates_controller.rb by brakeman

Injection is #1 on the 2013 OWASP Top Ten web security risks. SQL injection is when a user is able to manipulate a value which is used unsafely inside a SQL query. This can lead to data leaks, data loss, elevation of privilege, and other unpleasant outcomes.

Brakeman focuses on ActiveRecord methods dealing with building SQL statements.

A basic (Rails 2.x) example looks like this:

User.first(:conditions => "username = '#{params[:username]}'")

Brakeman would produce a warning like this:

Possible SQL injection near line 30: User.first(:conditions => ("username = '#{params[:username]}'"))

The safe way to do this query is to use a parameterized query:

User.first(:conditions => ["username = ?", params[:username]])

Brakeman also understands the new Rails 3.x way of doing things (and local variables and concatenation):

username = params[:user][:name].downcase
password = params[:user][:password]

User.first.where("username = '" + username + "' AND password = '" + password + "'")

This results in this kind of warning:

Possible SQL injection near line 37:
User.first.where((((("username = '" + params[:user][:name].downcase) + "' AND password = '") + params[:user][:password]) + "'"))

See the Ruby Security Guide for more information and Rails-SQLi.org for many examples of SQL injection in Rails.

Method has too many lines. [42/25]
Open

  def save_selected
    next_id = next_collecting_event_id
    selected = params[:selected]
    if selected.blank?
      message = 'Nothing to save.'
Severity: Minor
Found in app/controllers/tasks/collecting_events/parse/stepwise/dates_controller.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method has too many lines. [34/25]
Open

  def similar_labels
    retval = {}
    start_date = similar_params[:start_date]
    end_date = similar_params[:end_date]
    piece = similar_params[:piece]
Severity: Minor
Found in app/controllers/tasks/collecting_events/parse/stepwise/dates_controller.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method has too many lines. [31/25]
Open

  def update
    next_id = next_collecting_event_id
    ce = current_collecting_event
    any_failed = false
Severity: Minor
Found in app/controllers/tasks/collecting_events/parse/stepwise/dates_controller.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method save_selected has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

  def save_selected
    next_id = next_collecting_event_id
    selected = params[:selected]
    if selected.blank?
      message = 'Nothing to save.'
Severity: Minor
Found in app/controllers/tasks/collecting_events/parse/stepwise/dates_controller.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method save_selected has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def save_selected
    next_id = next_collecting_event_id
    selected = params[:selected]
    if selected.blank?
      message = 'Nothing to save.'
Severity: Minor
Found in app/controllers/tasks/collecting_events/parse/stepwise/dates_controller.rb - About 1 hr to fix

    Method similar_labels has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def similar_labels
    retval = {}
    start_date = similar_params[:start_date]
    end_date = similar_params[:end_date]
    piece = similar_params[:piece]
    Severity: Minor
    Found in app/controllers/tasks/collecting_events/parse/stepwise/dates_controller.rb - About 1 hr to fix

      Method update has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def update
    next_id = next_collecting_event_id
    ce = current_collecting_event
    any_failed = false
      Severity: Minor
      Found in app/controllers/tasks/collecting_events/parse/stepwise/dates_controller.rb - About 1 hr to fix

        Method similar_labels has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

          def similar_labels
    retval = {}
    start_date = similar_params[:start_date]
    end_date = similar_params[:end_date]
    piece = similar_params[:piece]
        Severity: Minor
        Found in app/controllers/tasks/collecting_events/parse/stepwise/dates_controller.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        TODO found
        Open

          # TODO: deprecate for valud from view/helper
        Severity: Minor
        Found in app/controllers/tasks/collecting_events/parse/stepwise/dates_controller.rb by fixme

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                  if ce.update({start_date_year: start_date[0],
              start_date_month: start_date[1],
              start_date_day: start_date[2],
              end_date_year: end_date[0],
              end_date_month: end_date[1],
        Severity: Minor
        Found in app/controllers/tasks/collecting_events/parse/stepwise/dates_controller.rb and 1 other location - About 40 mins to fix
        app/controllers/tasks/collecting_events/parse/stepwise/dates_controller.rb on lines 43..53

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 37.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            if ce.update({start_date_year: start_date[0],
        start_date_month: start_date[1],
        start_date_day: start_date[2],
        end_date_year: end_date[0],
        end_date_month: end_date[1],
        Severity: Minor
        Found in app/controllers/tasks/collecting_events/parse/stepwise/dates_controller.rb and 1 other location - About 40 mins to fix
        app/controllers/tasks/collecting_events/parse/stepwise/dates_controller.rb on lines 87..97

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 37.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          def collecting_event_id_param
    retval = nil
    begin
      retval = params.require(:collecting_event_id)
    rescue ActionController::ParameterMissing
        Severity: Minor
        Found in app/controllers/tasks/collecting_events/parse/stepwise/dates_controller.rb and 1 other location - About 35 mins to fix
        app/controllers/tasks/collecting_events/parse/stepwise/lat_long_controller.rb on lines 117..132

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 35.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status