Sign upLogin

SpeciesFileGroup/taxonworks

View on GitHub
Star
app/models/concerns/shared/is_data.rb

Summary

Maintainability
C
1 day
Test Coverage

Method is_in_use? has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

  def is_in_use?(exclude = [], only = [])
    if only.empty?
      self.class.reflect_on_all_associations(:has_many).each do |r|
        next if exclude.include?(r.name)
        return true if self.send(r.name).count(:all) > 0
Severity: Minor
Found in app/models/concerns/shared/is_data.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method is_destroyable? has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

  def is_destroyable?(user)
    u = user
    u = User.find(user) if !user.kind_of?(User)
    return true if u.is_administrator?
Severity: Minor
Found in app/models/concerns/shared/is_data.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method related_summary has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    def related_summary(ids)
      h = { restrict: {}, destroy: {} }
      objects = self.where(id: ids)

      base = self.table_name.to_sym
Severity: Minor
Found in app/models/concerns/shared/is_data.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method has too many lines. [26/25]
Open

    def related_summary(ids)
      h = { restrict: {}, destroy: {} }
      objects = self.where(id: ids)

      base = self.table_name.to_sym
Severity: Minor
Found in app/models/concerns/shared/is_data.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method related_summary has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def related_summary(ids)
      h = { restrict: {}, destroy: {} }
      objects = self.where(id: ids)

      base = self.table_name.to_sym
Severity: Minor
Found in app/models/concerns/shared/is_data.rb - About 1 hr to fix

    Use find_each instead of each.
    Open

              self.where(id: ids).each do |li|
    Severity: Minor
    Found in app/models/concerns/shared/is_data.rb by rubocop

    This cop is used to identify usages of all.each and change them to use all.find_each instead.

    Example:

    # bad
User.all.each

# good
User.all.find_each

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

          self.class.reflect_on_all_associations(:has_many).each do |r|
        next if exclude.include?(r.name)
        return true if self.send(r.name).count(:all) > 0
    Severity: Minor
    Found in app/models/concerns/shared/is_data.rb and 1 other location - About 15 mins to fix
    app/models/concerns/shared/is_data.rb on lines 206..208

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 25.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

          self.class.reflect_on_all_associations(:has_one).each do |r|
        next if exclude.include?(r.name)
        return true if self.send(r.name).count(:all) > 0
    Severity: Minor
    Found in app/models/concerns/shared/is_data.rb and 1 other location - About 15 mins to fix
    app/models/concerns/shared/is_data.rb on lines 201..203

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 25.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status