Sign upLogin

SpeciesFileGroup/taxonworks

View on GitHub
Star
app/models/identifier/global/isbn.rb

Summary

Maintainability
C
7 hrs
Test Coverage

Method has too many lines. [59/25]
Open

  def using_isbn_class
    unless identifier.nil?
      isbn = identifier.upcase
      # 'ISBN-13: 978-0-596-52068-7'
      isbn.gsub!('ISBN-10', '')
Severity: Minor
Found in app/models/identifier/global/isbn.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method using_isbn_class has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
Open

  def using_isbn_class
    unless identifier.nil?
      isbn = identifier.upcase
      # 'ISBN-13: 978-0-596-52068-7'
      isbn.gsub!('ISBN-10', '')
Severity: Minor
Found in app/models/identifier/global/isbn.rb - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method using_isbn_class has 59 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def using_isbn_class
    unless identifier.nil?
      isbn = identifier.upcase
      # 'ISBN-13: 978-0-596-52068-7'
      isbn.gsub!('ISBN-10', '')
Severity: Major
Found in app/models/identifier/global/isbn.rb - About 2 hrs to fix

    Consider simplifying this complex logical expression.
    Open

          if ($&.nil?) or
          (isbn_10.nil? and isbn_13.nil?) or
          ((isbn_10.nil? and type == '10') or (isbn_13.nil? and type == '13'))
        errors.add(:identifier, "'#{identifier}' has the wrong number of digits.")
        return
    Severity: Major
    Found in app/models/identifier/global/isbn.rb - About 1 hr to fix

      Avoid more than 3 levels of block nesting.
      Open

                if check_byte == 11
            check_byte = 0
          end
      Severity: Minor
      Found in app/models/identifier/global/isbn.rb by rubocop

      This cop checks for excessive nesting of conditional and looping constructs.

      You can configure if blocks are considered using the CountBlocks option. When set to false (the default) blocks are not counted towards the nesting level. Set to true to count blocks as well.

      The maximum level of nesting allowed is configurable.

      There are no issues that match your filters.

      Category
      Status