Sign upLogin

SpeciesFileGroup/taxonworks

View on GitHub
Star
app/models/observation_matrix_column_item.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Class ObservationMatrixColumnItem has 22 methods (exceeds 20 allowed). Consider refactoring.
Open

class ObservationMatrixColumnItem < ApplicationRecord
  include Housekeeping
  include Shared::Identifiers
  include Shared::Notes
  include Shared::Tags
Severity: Minor
Found in app/models/observation_matrix_column_item.rb - About 2 hrs to fix

    Method batch_create_from_pinboard has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

      def self.batch_create_from_pinboard(observation_matrix_id, project_id, user_id, klass)
    return false if observation_matrix_id.blank? || project_id.blank? || user_id.blank?
    created = []
    ObservationMatrixColumn.transaction do
      begin
    Severity: Minor
    Found in app/models/observation_matrix_column_item.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid using update_columns because it skips validations.
    Open

          mc.update_columns(cached_observation_matrix_column_item_id: nil) if current == 1 && type =~ /Single/ # we've deleted the only single, so the last must be a Dynamic/Tagged
    Severity: Minor
    Found in app/models/observation_matrix_column_item.rb by rubocop

    This cop checks for the use of methods which skip validations which are listed in https://guides.rubyonrails.org/active_record_validations.html#skipping-validations

    Methods may be ignored from this rule by configuring a Whitelist.

    Example:

    # bad
Article.first.decrement!(:view_count)
DiscussionBoard.decrement_counter(:post_count, 5)
Article.first.increment!(:view_count)
DiscussionBoard.increment_counter(:post_count, 5)
person.toggle :active
product.touch
Billing.update_all("category = 'authorized', author = 'David'")
user.update_attribute(:website, 'example.com')
user.update_columns(last_request_at: Time.current)
Post.update_counters 5, comment_count: -1, action_count: 1

# good
user.update(website: 'example.com')
FileUtils.touch('file')

    Example: Whitelist: ["touch"]

    # bad
DiscussionBoard.decrement_counter(:post_count, 5)
DiscussionBoard.increment_counter(:post_count, 5)
person.toggle :active

# good
user.touch

    Avoid using update_columns because it skips validations.
    Open

        mc.update_columns(reference_count: (mc.reference_count || 0) + 1)
    Severity: Minor
    Found in app/models/observation_matrix_column_item.rb by rubocop

    This cop checks for the use of methods which skip validations which are listed in https://guides.rubyonrails.org/active_record_validations.html#skipping-validations

    Methods may be ignored from this rule by configuring a Whitelist.

    Example:

    # bad
Article.first.decrement!(:view_count)
DiscussionBoard.decrement_counter(:post_count, 5)
Article.first.increment!(:view_count)
DiscussionBoard.increment_counter(:post_count, 5)
person.toggle :active
product.touch
Billing.update_all("category = 'authorized', author = 'David'")
user.update_attribute(:website, 'example.com')
user.update_columns(last_request_at: Time.current)
Post.update_counters 5, comment_count: -1, action_count: 1

# good
user.update(website: 'example.com')
FileUtils.touch('file')

    Example: Whitelist: ["touch"]

    # bad
DiscussionBoard.decrement_counter(:post_count, 5)
DiscussionBoard.increment_counter(:post_count, 5)
person.toggle :active

# good
user.touch

    Avoid using update_columns because it skips validations.
    Open

        mc.update_columns(cached_observation_matrix_column_item_id: id) if type =~ /Single/
    Severity: Minor
    Found in app/models/observation_matrix_column_item.rb by rubocop

    This cop checks for the use of methods which skip validations which are listed in https://guides.rubyonrails.org/active_record_validations.html#skipping-validations

    Methods may be ignored from this rule by configuring a Whitelist.

    Example:

    # bad
Article.first.decrement!(:view_count)
DiscussionBoard.decrement_counter(:post_count, 5)
Article.first.increment!(:view_count)
DiscussionBoard.increment_counter(:post_count, 5)
person.toggle :active
product.touch
Billing.update_all("category = 'authorized', author = 'David'")
user.update_attribute(:website, 'example.com')
user.update_columns(last_request_at: Time.current)
Post.update_counters 5, comment_count: -1, action_count: 1

# good
user.update(website: 'example.com')
FileUtils.touch('file')

    Example: Whitelist: ["touch"]

    # bad
DiscussionBoard.decrement_counter(:post_count, 5)
DiscussionBoard.increment_counter(:post_count, 5)
person.toggle :active

# good
user.touch

    Use find_each instead of each.
    Open

              klass.constantize.joins(:pinboard_items).where(pinboard_items: {user_id: user_id, project_id: project_id}).each do |o|
    Severity: Minor
    Found in app/models/observation_matrix_column_item.rb by rubocop

    This cop is used to identify usages of all.each and change them to use all.find_each instead.

    Example:

    # bad
User.all.each

# good
User.all.find_each

    Avoid using update_columns because it skips validations.
    Open

          mc.update_columns(reference_count: current)
    Severity: Minor
    Found in app/models/observation_matrix_column_item.rb by rubocop

    This cop checks for the use of methods which skip validations which are listed in https://guides.rubyonrails.org/active_record_validations.html#skipping-validations

    Methods may be ignored from this rule by configuring a Whitelist.

    Example:

    # bad
Article.first.decrement!(:view_count)
DiscussionBoard.decrement_counter(:post_count, 5)
Article.first.increment!(:view_count)
DiscussionBoard.increment_counter(:post_count, 5)
person.toggle :active
product.touch
Billing.update_all("category = 'authorized', author = 'David'")
user.update_attribute(:website, 'example.com')
user.update_columns(last_request_at: Time.current)
Post.update_counters 5, comment_count: -1, action_count: 1

# good
user.update(website: 'example.com')
FileUtils.touch('file')

    Example: Whitelist: ["touch"]

    # bad
DiscussionBoard.decrement_counter(:post_count, 5)
DiscussionBoard.increment_counter(:post_count, 5)
person.toggle :active

# good
user.touch

    Use type.present? instead of !type.blank?.
    Open

      validate :other_subclass_attributes_not_set, if: -> { !type.blank? }
    Severity: Minor
    Found in app/models/observation_matrix_column_item.rb by rubocop

    This cop checks for code that can be written with simpler conditionals using Object#present? defined by Active Support.

    Interaction with Style/UnlessElse: The configuration of NotBlank will not produce an offense in the context of unless else if Style/UnlessElse is inabled. This is to prevent interference between the auto-correction of the two cops.

    Example: NotNilAndNotEmpty: true (default)

    # Converts usages of `!nil? && !empty?` to `present?`

# bad
!foo.nil? && !foo.empty?

# bad
foo != nil && !foo.empty?

# good
foo.present?

    Example: NotBlank: true (default)

    # Converts usages of `!blank?` to `present?`

# bad
!foo.blank?

# bad
not foo.blank?

# good
foo.present?

    Example: UnlessBlank: true (default)

    # Converts usages of `unless blank?` to `if present?`

# bad
something unless foo.blank?

# good
something if foo.present?

    Use find_by instead of where.first.
    Open

        mc ||= ObservationMatrixColumn.where(
      descriptor_id: descriptor_id,
      observation_matrix: observation_matrix
    ).first
    Severity: Minor
    Found in app/models/observation_matrix_column_item.rb by rubocop

    This cop is used to identify usages of where.first and change them to use find_by instead.

    Example:

    # bad
User.where(name: 'Bruce').first
User.where(name: 'Bruce').take

# good
User.find_by(name: 'Bruce')

    Use find_each instead of each.
    Open

        ObservationMatrixColumn.where(descriptor_id: descriptors.map(&:id), observation_matrix: observation_matrix).each do |mc|
    Severity: Minor
    Found in app/models/observation_matrix_column_item.rb by rubocop

    This cop is used to identify usages of all.each and change them to use all.find_each instead.

    Example:

    # bad
User.all.each

# good
User.all.find_each

    Use find_each instead of each.
    Open

              klass.constantize.joins(:tags).where(tags: {keyword_id: keyword_id } ).each do |o|
    Severity: Minor
    Found in app/models/observation_matrix_column_item.rb by rubocop

    This cop is used to identify usages of all.each and change them to use all.find_each instead.

    Example:

    # bad
User.all.each

# good
User.all.find_each

    Use send(atr).present? instead of !send(atr).blank?.
    Open

          errors.add(atr, 'is not valid for this type of observation matrix column item') if !send(atr).blank?
    Severity: Minor
    Found in app/models/observation_matrix_column_item.rb by rubocop

    This cop checks for code that can be written with simpler conditionals using Object#present? defined by Active Support.

    Interaction with Style/UnlessElse: The configuration of NotBlank will not produce an offense in the context of unless else if Style/UnlessElse is inabled. This is to prevent interference between the auto-correction of the two cops.

    Example: NotNilAndNotEmpty: true (default)

    # Converts usages of `!nil? && !empty?` to `present?`

# bad
!foo.nil? && !foo.empty?

# bad
foo != nil && !foo.empty?

# good
foo.present?

    Example: NotBlank: true (default)

    # Converts usages of `!blank?` to `present?`

# bad
!foo.blank?

# bad
not foo.blank?

# good
foo.present?

    Example: UnlessBlank: true (default)

    # Converts usages of `unless blank?` to `if present?`

# bad
something unless foo.blank?

# good
something if foo.present?

    TODO found
    Open

      # TODO: remove from subclasses WHY does this need to be here
    Severity: Minor
    Found in app/models/observation_matrix_column_item.rb by fixme

    Prefer the new style validations validates :column, presence: value over validates_presence_of.
    Open

      validates_presence_of :observation_matrix
    Severity: Minor
    Found in app/models/observation_matrix_column_item.rb by rubocop

    This cop checks for the use of old-style attribute validation macros.

    Example:

    # bad
validates_acceptance_of :foo
validates_confirmation_of :foo
validates_exclusion_of :foo
validates_format_of :foo
validates_inclusion_of :foo
validates_length_of :foo
validates_numericality_of :foo
validates_presence_of :foo
validates_absence_of :foo
validates_size_of :foo
validates_uniqueness_of :foo

# good
validates :foo, acceptance: true
validates :foo, confirmation: true
validates :foo, exclusion: true
validates :foo, format: true
validates :foo, inclusion: true
validates :foo, length: true
validates :foo, numericality: true
validates :foo, presence: true
validates :foo, absence: true
validates :foo, size: true
validates :foo, uniqueness: true

    There are no issues that match your filters.

    Category
    Status