SpeciesFileGroup/taxonworks

View on GitHub
lib/batch_load/import/collection_objects.rb

Summary

Maintainability
D
2 days
Test Coverage

Method build_collection_objects has a Cognitive Complexity of 37 (exceeds 5 allowed). Consider refactoring.
Open

    def build_collection_objects
      # test_build
      build_objects = {}
      i             = 1 # accounting for headers
      # identifier namespace
Severity: Minor
Found in lib/batch_load/import/collection_objects.rb - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method build_collection_objects has 128 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def build_collection_objects
      # test_build
      build_objects = {}
      i             = 1 # accounting for headers
      # identifier namespace
Severity: Major
Found in lib/batch_load/import/collection_objects.rb - About 5 hrs to fix

    Method build_collection_objects_ori has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
    Open

        def build_collection_objects_ori
          ce_a1         = ''
          ce_m1         = ''
          ce1           = CollectingEvent.find(1)
          # here we store the attributes of stuff we want to find later
    Severity: Minor
    Found in lib/batch_load/import/collection_objects.rb - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method build_collection_objects_ori has 67 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def build_collection_objects_ori
          ce_a1         = ''
          ce_m1         = ''
          ce1           = CollectingEvent.find(1)
          # here we store the attributes of stuff we want to find later
    Severity: Major
    Found in lib/batch_load/import/collection_objects.rb - About 2 hrs to fix

      There are no issues that match your filters.

      Category
      Status