SpeciesFileGroup/taxonworks

View on GitHub
lib/catalog/entry_item.rb

Summary

Maintainability
A
0 mins
Test Coverage

TODO found
Open

  # !!TODO: we should not be checking at this point.
Severity: Minor
Found in lib/catalog/entry_item.rb by fixme

TODO found
Open

  # TODO: optimize indecies so this is not needed.
Severity: Minor
Found in lib/catalog/entry_item.rb by fixme

TODO found
Open

  # !!TODO: change to _must be_ explicitly assigned
Severity: Minor
Found in lib/catalog/entry_item.rb by fixme

Prefer symbols instead of strings as hash keys.
Open

      'history-is-current-target' => matches_current_target
Severity: Minor
Found in lib/catalog/entry_item.rb by rubocop

This cop checks for the use of strings as keys in hashes. The use of symbols is preferred instead.

Example:

# bad
{ 'one' => 1, 'two' => 2, 'three' => 3 }

# good
{ one: 1, two: 2, three: 3 }

Prefer symbols instead of strings as hash keys.
Open

      'history-is-cited' => (citation ? true : false),
Severity: Minor
Found in lib/catalog/entry_item.rb by rubocop

This cop checks for the use of strings as keys in hashes. The use of symbols is preferred instead.

Example:

# bad
{ 'one' => 1, 'two' => 2, 'three' => 3 }

# good
{ one: 1, two: 2, three: 3 }

Prefer symbols instead of strings as hash keys.
Open

      'history-object-id' => object.to_global_id.to_s,
Severity: Minor
Found in lib/catalog/entry_item.rb by rubocop

This cop checks for the use of strings as keys in hashes. The use of symbols is preferred instead.

Example:

# bad
{ 'one' => 1, 'two' => 2, 'three' => 3 }

# good
{ one: 1, two: 2, three: 3 }

Prefer symbols instead of strings as hash keys.
Open

      'history-origin' => origin,
Severity: Minor
Found in lib/catalog/entry_item.rb by rubocop

This cop checks for the use of strings as keys in hashes. The use of symbols is preferred instead.

Example:

# bad
{ 'one' => 1, 'two' => 2, 'three' => 3 }

# good
{ one: 1, two: 2, three: 3 }

Prefer symbols instead of strings as hash keys.
Open

      'history-is-last' => is_last,
Severity: Minor
Found in lib/catalog/entry_item.rb by rubocop

This cop checks for the use of strings as keys in hashes. The use of symbols is preferred instead.

Example:

# bad
{ 'one' => 1, 'two' => 2, 'three' => 3 }

# good
{ one: 1, two: 2, three: 3 }

Prefer symbols instead of strings as hash keys.
Open

      'history-year' => nomenclature_date&.year || 'unknown',
Severity: Minor
Found in lib/catalog/entry_item.rb by rubocop

This cop checks for the use of strings as keys in hashes. The use of symbols is preferred instead.

Example:

# bad
{ 'one' => 1, 'two' => 2, 'three' => 3 }

# good
{ one: 1, two: 2, three: 3 }

Prefer symbols instead of strings as hash keys.
Open

      'history-is-first' => is_first,
Severity: Minor
Found in lib/catalog/entry_item.rb by rubocop

This cop checks for the use of strings as keys in hashes. The use of symbols is preferred instead.

Example:

# bad
{ 'one' => 1, 'two' => 2, 'three' => 3 }

# good
{ one: 1, two: 2, three: 3 }

There are no issues that match your filters.

Category
Status