Sign upLogin

SpeciesFileGroup/taxonworks

View on GitHub
Star
lib/queries/concerns/identifiers.rb

Summary

Maintainability
D
1 day
Test Coverage

File identifiers.rb has 281 lines of code (exceeds 250 allowed). Consider refactoring.
Open

module Queries::Concerns::Identifiers
  include Queries::Helpers

  extend ActiveSupport::Concern
Severity: Minor
Found in lib/queries/concerns/identifiers.rb - About 2 hrs to fix

    Method local_identifiers_facet has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

      def local_identifiers_facet
    return nil if local_identifiers.nil?
    a = nil

    if local_identifiers
    Severity: Minor
    Found in lib/queries/concerns/identifiers.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method global_identifiers_facet has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

      def global_identifiers_facet
    return nil if global_identifiers.nil?
    a = nil

    if global_identifiers
    Severity: Minor
    Found in lib/queries/concerns/identifiers.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method global_identifiers_facet has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

      def global_identifiers_facet
    return nil if global_identifiers.nil?
    a = nil

    if global_identifiers
    Severity: Minor
    Found in lib/queries/concerns/identifiers.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    TODO found
    Open

      # TODO: Simplify local/global copy-pasta
    Severity: Minor
    Found in lib/queries/concerns/identifiers.rb by fixme

    TODO found
    Open

        # TODO: this logic can almost certainly be simplified.  Test coverage is decent for attempts to do so.
    Severity: Minor
    Found in lib/queries/concerns/identifiers.rb by fixme

    TODO found
    Open

        w = w.and(identifier_table[:namespace_id].eq(namespace_id)) if namespace_id # TODO: redundant with namespace facet likely
    Severity: Minor
    Found in lib/queries/concerns/identifiers.rb by fixme

    TODO found
    Open

        # TODO: this logic can almost certainly be simplified.  Test coverage is decent for attempts to do so.
    Severity: Minor
    Found in lib/queries/concerns/identifiers.rb by fixme

    TODO found
    Open

      # TODO: make generic autcomplete include for all methos optimized
    Severity: Minor
    Found in lib/queries/concerns/identifiers.rb by fixme

    TODO found
    Open

        # TODO: this logic can almost certainly be simplified.  Test coverage is decent for attempts to do so.
    Severity: Minor
    Found in lib/queries/concerns/identifiers.rb by fixme

    TODO found
    Open

    # TODO: Some of this is only for autocomplete !!
    Severity: Minor
    Found in lib/queries/concerns/identifiers.rb by fixme

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

      def local_identifiers_facet
    return nil if local_identifiers.nil?
    a = nil

    if local_identifiers
    Severity: Major
    Found in lib/queries/concerns/identifiers.rb and 2 other locations - About 2 hrs to fix
    lib/queries/concerns/identifiers.rb on lines 221..249
    lib/queries/concerns/identifiers.rb on lines 284..312

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 97.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

      def global_identifiers_facet
    return nil if global_identifiers.nil?
    a = nil

    if global_identifiers
    Severity: Major
    Found in lib/queries/concerns/identifiers.rb and 2 other locations - About 2 hrs to fix
    lib/queries/concerns/identifiers.rb on lines 252..280
    lib/queries/concerns/identifiers.rb on lines 284..312

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 97.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

      def global_identifiers_facet
    return nil if global_identifiers.nil?
    a = nil

    if global_identifiers
    Severity: Major
    Found in lib/queries/concerns/identifiers.rb and 2 other locations - About 2 hrs to fix
    lib/queries/concerns/identifiers.rb on lines 221..249
    lib/queries/concerns/identifiers.rb on lines 252..280

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 97.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      def set_identifier_params(params)

    @global_identifiers = boolean_param(params, :global_identifiers)
    @identifier = params[:identifier]
    @identifier_end = params[:identifier_end]
    Severity: Major
    Found in lib/queries/concerns/identifiers.rb and 1 other location - About 1 hr to fix
    lib/queries/concerns/data_attributes.rb on lines 171..185

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 50.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status