Sign upLogin

SpeciesFileGroup/taxonworks

View on GitHub
Star
lib/queries/serial/autocomplete.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method has too many lines. [37/25]
Open

      def autocomplete
        queries = [
          autocomplete_exact_name,
          #autocomplete_exact_alternate_value,
          autocomplete_exact_alternate_value('name', 'AlternateValue::Translation'),
Severity: Minor
Found in lib/queries/serial/autocomplete.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method autocomplete has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def autocomplete
        queries = [
          autocomplete_exact_name,
          #autocomplete_exact_alternate_value,
          autocomplete_exact_alternate_value('name', 'AlternateValue::Translation'),
Severity: Minor
Found in lib/queries/serial/autocomplete.rb - About 1 hr to fix

    Method autocomplete has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

          def autocomplete
        queries = [
          autocomplete_exact_name,
          #autocomplete_exact_alternate_value,
          autocomplete_exact_alternate_value('name', 'AlternateValue::Translation'),
    Severity: Minor
    Found in lib/queries/serial/autocomplete.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    TODO found
    Open

          # TODO: these three should be factored out to just the join, made more Arel like
    Severity: Minor
    Found in lib/queries/serial/autocomplete.rb by fixme

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

          def autocomplete_exact_alternate_value(attribute = 'name', type = 'AlternateValue')
        ::Serial.joins(:alternate_values).where(
          alternate_value_table[:type].eq(type).and(
          alternate_value_table[:alternate_value_object_attribute].eq(attribute).
          and(alternate_value_table[:value].eq(query_string))).to_sql
    Severity: Minor
    Found in lib/queries/serial/autocomplete.rb and 1 other location - About 25 mins to fix
    lib/queries/serial/autocomplete.rb on lines 82..87

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 30.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

          def autocomplete_ordered_wildcard_alternate_value(attribute = 'name', type = 'AlternateValue')
        ::Serial.joins(:alternate_values).where(
          alternate_value_table[:type].eq(type).and(
          alternate_value_table[:alternate_value_object_attribute].eq(attribute).
          and(alternate_value_table[:value].matches(wildcard_pieces))).to_sql
    Severity: Minor
    Found in lib/queries/serial/autocomplete.rb and 1 other location - About 25 mins to fix
    lib/queries/serial/autocomplete.rb on lines 90..95

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 30.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status