Sign upLogin

SpeciesFileGroup/taxonworks

View on GitHub
Star
lib/queries/source/autocomplete.rb

Summary

Maintainability
B
7 hrs
Test Coverage

Method has too many lines. [39/25]
Open

      def autocomplete

        # [ query, order by use if true- don't if nil ]
        queries = [
          [ autocomplete_exact_id, false],
Severity: Minor
Found in lib/queries/source/autocomplete.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Class Autocomplete has 26 methods (exceeds 20 allowed). Consider refactoring.
Open

    class Autocomplete < Query::Autocomplete

      # Either match against all Sources (default) or just those with ProjectSource
      # @return [Boolean]
      # @param limit_to_project [String] `true` or `false`
Severity: Minor
Found in lib/queries/source/autocomplete.rb - About 3 hrs to fix

    Method autocomplete has 39 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def autocomplete

        # [ query, order by use if true- don't if nil ]
        queries = [
          [ autocomplete_exact_id, false],
    Severity: Minor
    Found in lib/queries/source/autocomplete.rb - About 1 hr to fix

      Method autocomplete has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

            def autocomplete

        # [ query, order by use if true- don't if nil ]
        queries = [
          [ autocomplete_exact_id, false],
      Severity: Minor
      Found in lib/queries/source/autocomplete.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

            def autocomplete_exact_author_year
        return nil if query_string.split(' ').count > 2
        a = match_exact_author
        d = match_year
        return nil if a.nil? || d.nil?
      Severity: Minor
      Found in lib/queries/source/autocomplete.rb and 2 other locations - About 25 mins to fix
      lib/queries/source/autocomplete.rb on lines 107..113
      lib/queries/source/autocomplete.rb on lines 117..123

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 31.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

            def autocomplete_start_author_year
        return nil if query_string.split(' ').count > 2
        a = match_start_author
        d = match_year
        return nil if a.nil? || d.nil?
      Severity: Minor
      Found in lib/queries/source/autocomplete.rb and 2 other locations - About 25 mins to fix
      lib/queries/source/autocomplete.rb on lines 97..103
      lib/queries/source/autocomplete.rb on lines 117..123

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 31.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

            def autocomplete_wildcard_author_exact_year
        return nil if query_string.split(' ').count > 2
        a = match_year
        d = match_wildcard_author
        return nil if a.nil? || d.nil?
      Severity: Minor
      Found in lib/queries/source/autocomplete.rb and 2 other locations - About 25 mins to fix
      lib/queries/source/autocomplete.rb on lines 97..103
      lib/queries/source/autocomplete.rb on lines 107..113

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 31.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status