SpeciesFileGroup/taxonworks

View on GitHub
lib/queries/taxon_name/autocomplete.rb

Summary

Maintainability
C
1 day
Test Coverage

Class Autocomplete has 37 methods (exceeds 20 allowed). Consider refactoring.
Open

    class Autocomplete < Queries::Query

      # @return [Array, nil]
      #   &nomenclature_group[]=<<Iczn|Icnp|Icn>::<Higher|Family|Genus|Species>>
      attr_accessor :nomenclature_group
Severity: Minor
Found in lib/queries/taxon_name/autocomplete.rb - About 4 hrs to fix

    File autocomplete.rb has 262 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    module Queries
      module TaxonName
        class Autocomplete < Queries::Query
    
          # @return [Array, nil]
    Severity: Minor
    Found in lib/queries/taxon_name/autocomplete.rb - About 2 hrs to fix

      Method initialize has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

            def initialize(string, project_id: nil, valid: nil, exact: nil, no_leaves: nil, nomenclature_group: [], type: [], parent_id: [])
              @nomenclature_group = nomenclature_group
              @valid = valid == 'true' ? true : (valid == 'false' ? false : nil)
              @type = type
              @parent_id = parent_id
      Severity: Minor
      Found in lib/queries/taxon_name/autocomplete.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method autocomplete has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

            def autocomplete
              queries = (exact ? exact_autocomplete : comprehensive_autocomplete)
              queries.compact!
      
              result = []
      Severity: Minor
      Found in lib/queries/taxon_name/autocomplete.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method authorship has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

            def authorship
              parser = ::Biodiversity::Parser
              a = parser.parse(query_string)
              b = a
              return nil if b.nil? or b[:details].nil?
      Severity: Minor
      Found in lib/queries/taxon_name/autocomplete.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      TODO found
      Open

            # !! TODO: should be autocomplete and array ...

      TODO found
      Open

                a = a.where(and_clauses.to_sql) if and_clauses # TODO: duplicates clauses like exact!!

      Similar blocks of code found in 6 locations. Consider refactoring.
      Open

            def and_clauses
              clauses = [
                valid_state,
                is_type,
                with_parent_id,
      Severity: Minor
      Found in lib/queries/taxon_name/autocomplete.rb and 5 other locations - About 15 mins to fix
      lib/queries/biological_association/filter.rb on lines 26..40
      lib/queries/common_name/filter.rb on lines 37..51
      lib/queries/controlled_vocabulary_term/autocomplete.rb on lines 30..44
      lib/queries/otu/filter.rb on lines 395..411
      lib/queries/person/filter.rb on lines 50..64

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 26.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status