Sign upLogin

SpontaneousCMS/spontaneous

View on GitHub
Star
application/js/field/file.js

Summary

Maintainability
F
3 days
Test Coverage

Function File has 258 lines of code (exceeds 25 allowed). Consider refactoring.
Open

Spontaneous.Field.File = (function($, S) {
    var dom = S.Dom;
    var FileField = new JS.Class(Spontaneous.Field.String, {
        selected_files: false,
Severity: Major
Found in application/js/field/file.js - About 1 day to fix

    Function File has a Cognitive Complexity of 37 (exceeds 5 allowed). Consider refactoring.
    Open

    Spontaneous.Field.File = (function($, S) {
    var dom = S.Dom;
    var FileField = new JS.Class(Spontaneous.Field.String, {
        selected_files: false,
    Severity: Minor
    Found in application/js/field/file.js - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function edit has 67 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            edit: function() {
            var self = this;
            var wrap = dom.div('.file-field', {'style':'position:relative;'});
            var value = this.value();
            var input = this.input();
    Severity: Major
    Found in application/js/field/file.js - About 2 hrs to fix

      File file.js has 260 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      // console.log('Loading FileField...')
Spontaneous.Field.File = (function($, S) {
    var dom = S.Dom;
    var FileField = new JS.Class(Spontaneous.Field.String, {
        selected_files: false,
      Severity: Minor
      Found in application/js/field/file.js - About 2 hrs to fix

        Function preview has 52 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                preview: function() {
            Spontaneous.UploadManager.register(this);
            var self = this
, value = this.currentValue()
            , filename = this.currentFilename();
        Severity: Major
        Found in application/js/field/file.js - About 2 hrs to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  currentEditValue: function() {
            var value, pending, ui, v = this.get('value');
            if ((pending = v.__pending__)) {
                return pending.value;
            }
          Severity: Major
          Found in application/js/field/file.js and 1 other location - About 4 hrs to fix
          application/js/field/image.js on lines 70..81

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 115.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                              S.Ajax.test_field_versions(this.content, [this], this.upload_values.bind(this), this.upload_conflict.bind(this));
          Severity: Minor
          Found in application/js/field/file.js and 1 other location - About 40 mins to fix
          application/js/field/image.js on lines 171..171

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 48.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

                      var drag_enter = function(event) {
                stopEvent(event);
                $(this).addClass('drop-active');
                return false;
            }.bind(dropper);
          Severity: Major
          Found in application/js/field/file.js and 3 other locations - About 35 mins to fix
          application/js/field/file.js on lines 66..70
          application/js/field/file.js on lines 77..81
          application/js/field/file.js on lines 234..238

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 46.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

                      var drag_leave = function(event) {
                stopEvent(event);
                $(this).removeClass('drop-active');
                return false;
            }.bind(dropper);
          Severity: Major
          Found in application/js/field/file.js and 3 other locations - About 35 mins to fix
          application/js/field/file.js on lines 66..70
          application/js/field/file.js on lines 223..227
          application/js/field/file.js on lines 234..238

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 46.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

                      var drag_leave = function(event) {
                stopEvent(event);
                $(this).removeClass('drop-active');
                return false;
            }.bind(dropper);
          Severity: Major
          Found in application/js/field/file.js and 3 other locations - About 35 mins to fix
          application/js/field/file.js on lines 66..70
          application/js/field/file.js on lines 77..81
          application/js/field/file.js on lines 223..227

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 46.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

                      var drag_enter = function(event) {
                stopEvent(event);
                $(this).addClass('drop-active');
                return false;
            }.bind(dropper);
          Severity: Major
          Found in application/js/field/file.js and 3 other locations - About 35 mins to fix
          application/js/field/file.js on lines 77..81
          application/js/field/file.js on lines 223..227
          application/js/field/file.js on lines 234..238

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 46.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                      var set_info = function(href, filename, filesize) {
                filename_info.text(filename);
                if (filesize) {
                    filesize_info.text(parseFloat(filesize, 10).to_filesize());
                }
          Severity: Minor
          Found in application/js/field/file.js and 1 other location - About 30 mins to fix
          application/js/field/file.js on lines 174..179

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 45.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                      var set_info = function(filename, filesize) {
                filename_info.text(filename);
                if (filesize) {
                    filesize_info.text(parseFloat(filesize, 10).to_filesize());
                }
          Severity: Minor
          Found in application/js/field/file.js and 1 other location - About 30 mins to fix
          application/js/field/file.js on lines 90..95

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 45.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status