Sign upLogin

SpontaneousCMS/spontaneous

View on GitHub
Star
application/js/meta_view/user_admin.js

Summary

Maintainability
F
4 days
Test Coverage

Function UserAdmin has 507 lines of code (exceeds 25 allowed). Consider refactoring.
Open

Spontaneous.MetaView.UserAdmin = (function($, S){
    var dom = S.Dom, ajax = S.Ajax;

    var Level = new JS.Class({
        initialize: function(attributes) {
Severity: Major
Found in application/js/meta_view/user_admin.js - About 2 days to fix

    File user_admin.js has 509 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    Spontaneous.MetaView.UserAdmin = (function($, S){
    var dom = S.Dom, ajax = S.Ajax;

    var Level = new JS.Class({
        initialize: function(attributes) {
    Severity: Major
    Found in application/js/meta_view/user_admin.js - About 1 day to fix

      Function UserAdmin has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
      Open

      Spontaneous.MetaView.UserAdmin = (function($, S){
    var dom = S.Dom, ajax = S.Ajax;

    var Level = new JS.Class({
        initialize: function(attributes) {
      Severity: Minor
      Found in application/js/meta_view/user_admin.js - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function view has 41 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              view: function() {
            var self = this;
            var user = this.user;
            var wrap = dom.div();
            var form = dom.form({method: 'post', action: ajax.request_url('/users/'+ user.get('id'))});
      Severity: Minor
      Found in application/js/meta_view/user_admin.js - About 1 hr to fix

        Function element has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                element: function(cancelCallback) {
            var self = this;
            var levels = Level.levels;
            var currentLevel = Level.get(this.user.get('level')) || Level.defaultLevel();
            var outer = dom.div('.level-select');
        Severity: Minor
        Found in application/js/meta_view/user_admin.js - About 1 hr to fix

          Function listEntry has 29 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  listEntry: function(user) {
            var self = this;
            var row = dom.div('.user');
            row.attr('id', 'user-admin-' + user.get('id'));
            var cells = ['name', 'level'].map(function(attr) {
          Severity: Minor
          Found in application/js/meta_view/user_admin.js - About 1 hr to fix

            Function aboveUserAttributes has 28 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                    aboveUserAttributes: function() {
            var self = this;
            var user = this.user;
            var admin = dom.div('.admin');
            p = dom.p('.enabled');
            Severity: Minor
            Found in application/js/meta_view/user_admin.js - About 1 hr to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                              row.append(dom.span('.level-admin').text('Admin').addClass(''+level.isAdmin()));
              Severity: Minor
              Found in application/js/meta_view/user_admin.js and 1 other location - About 35 mins to fix
              application/js/meta_view/user_admin.js on lines 54..54

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 46.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                          var done = dom.a('.button.done').text('Done').click(function() {
                self.close();
            });
              Severity: Minor
              Found in application/js/meta_view/user_admin.js and 1 other location - About 35 mins to fix
              application/js/meta_view/user_admin.js on lines 396..398

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 46.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                          var addButton = dom.a('.button.add').text('Create User').click(function() {
                self.createUser();
            });
              Severity: Minor
              Found in application/js/meta_view/user_admin.js and 1 other location - About 35 mins to fix
              application/js/meta_view/user_admin.js on lines 392..394

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 46.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                              row.append(dom.span('.level-publish').text('Publish').addClass(''+level.canPublish()));
              Severity: Minor
              Found in application/js/meta_view/user_admin.js and 1 other location - About 35 mins to fix
              application/js/meta_view/user_admin.js on lines 55..55

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 46.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status