Sign upLogin

SpontaneousCMS/spontaneous

View on GitHub
Star
application/js/publish.js

Summary

Maintainability
F
5 days
Test Coverage

Function Publishing has 408 lines of code (exceeds 25 allowed). Consider refactoring.
Open

Spontaneous.Publishing = (function($, S) {
    var dom = S.Dom, Dialogue = Spontaneous.Dialogue, User = S.User;

    var PublishingDialogue = new JS.Class(Dialogue, {
        initialize: function(content) {
Severity: Major
Found in application/js/publish.js - About 2 days to fix

    Function Publishing has a Cognitive Complexity of 80 (exceeds 5 allowed). Consider refactoring.
    Open

    Spontaneous.Publishing = (function($, S) {
    var dom = S.Dom, Dialogue = Spontaneous.Dialogue, User = S.User;

    var PublishingDialogue = new JS.Class(Dialogue, {
        initialize: function(content) {
    Severity: Minor
    Found in application/js/publish.js - About 1 day to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File publish.js has 410 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    // console.log('Loading Publishing...')

Spontaneous.Publishing = (function($, S) {
    var dom = S.Dom, Dialogue = Spontaneous.Dialogue, User = S.User;
    Severity: Minor
    Found in application/js/publish.js - About 5 hrs to fix

      Function change_list_loaded has 76 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              change_list_loaded: function(outstanding) {
            var change_list = outstanding.changes
            , w = this.wrapper
            , self = this
            , changed_wrap = dom.div('#changes.change-list').css('opacity', 0)
      Severity: Major
      Found in application/js/publish.js - About 3 hrs to fix

        Function createPanel has 45 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                createPanel: function() {
            var w = dom.div('.change-set')
            , inner = dom.div('.inner')
            , page_list = dom.div('.pages')
            , add = dom.div('.add').append(dom.span().text(''))
        Severity: Minor
        Found in application/js/publish.js - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                          var publish_all = dom.a('.button').text('Publish All').click(function() {
                    self.set_publish_all(true);
                }.bind(self));
          Severity: Major
          Found in application/js/publish.js and 1 other location - About 1 hr to fix
          application/js/publish.js on lines 105..107

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 55.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                          var clear_all = dom.a('.button').text('Clear All').click(function() {
                    self.set_publish_all(false);
                }.bind(self));
          Severity: Major
          Found in application/js/publish.js and 1 other location - About 1 hr to fix
          application/js/publish.js on lines 102..104

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 55.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status