Sign upLogin

SpontaneousCMS/spontaneous

View on GitHub
Star
application/js/top_bar.js

Summary

Maintainability
F
1 wk
Test Coverage

Function TopBar has 606 lines of code (exceeds 25 allowed). Consider refactoring.
Open

Spontaneous.TopBar = (function($, S) {
    var dom = S.Dom, Ajax = S.Ajax;

    var disableParent = function(el) {
        el.hover(function() {
Severity: Major
Found in application/js/top_bar.js - About 3 days to fix

    Function TopBar has a Cognitive Complexity of 130 (exceeds 5 allowed). Consider refactoring.
    Open

    Spontaneous.TopBar = (function($, S) {
    var dom = S.Dom, Ajax = S.Ajax;

    var disableParent = function(el) {
        el.hover(function() {
    Severity: Minor
    Found in application/js/top_bar.js - About 2 days to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File top_bar.js has 608 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    // console.log("Loading TopBar...")

Spontaneous.TopBar = (function($, S) {
    var dom = S.Dom, Ajax = S.Ajax;
    Severity: Major
    Found in application/js/top_bar.js - About 1 day to fix

      Function update_navigation has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              update_navigation: function(location) {
            var nodes = [];
            // var location = this.get('location');
            var $location_bar = this.location;
            if (typeof location.ancestors === 'undefined') {
      Severity: Minor
      Found in application/js/top_bar.js - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            var slugComparator = function(a, b) {
        var at = a.slug, bt = b.slug;
        if (at > bt) { return 1; }
        if (at < bt) { return -1; }
        return 0;
        Severity: Major
        Found in application/js/top_bar.js and 1 other location - About 1 hr to fix
        application/js/add_alias_dialogue.js on lines 239..244

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 67.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                        link.click(function() {
                    var page = $(this).data('page');
                    S.Location.load_id(page.id);
                    return false;
                });
        Severity: Minor
        Found in application/js/top_bar.js and 1 other location - About 40 mins to fix
        application/js/top_bar.js on lines 200..204

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 48.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                    var page = this.page, li = dom.li('.ancestor-node'), link = $('<a/>').data('page', page).click(function() {
                var page = $(this).data('page');
                S.Location.load_id(page.id);
                return false;
            }).text(this.title);
        Severity: Minor
        Found in application/js/top_bar.js and 1 other location - About 40 mins to fix
        application/js/top_bar.js on lines 176..180

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 48.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status