SpontaneousCMS/spontaneous

View on GitHub
lib/spontaneous/utils/smart_quotes.rb

Summary

Maintainability
D
2 days
Test Coverage

Method smarten has a Cognitive Complexity of 89 (exceeds 5 allowed). Consider refactoring.
Open

    def smarten(string, options=[2])
      do_quotes = do_backticks = do_dashes = do_ellipses = do_stupify = nil
      convert_quotes = false

      if options.include? 0
Severity: Minor
Found in lib/spontaneous/utils/smart_quotes.rb - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method smarten has 76 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def smarten(string, options=[2])
      do_quotes = do_backticks = do_dashes = do_ellipses = do_stupify = nil
      convert_quotes = false

      if options.include? 0
Severity: Major
Found in lib/spontaneous/utils/smart_quotes.rb - About 3 hrs to fix

    Avoid deeply nested control flow statements.
    Open

                  elsif t == '"'
                    # Special case: single-character " token
                    if prev_token_last_char =~ /\S/
                      t = CLOSE_DBL_QUOTE
                    else
    Severity: Major
    Found in lib/spontaneous/utils/smart_quotes.rb - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                      if prev_token_last_char =~ /\S/
                        t = CLOSE_SGL_QUOTE
                      else
                        t = OPEN_SGL_QUOTE
                      end
      Severity: Major
      Found in lib/spontaneous/utils/smart_quotes.rb - About 45 mins to fix

        There are no issues that match your filters.

        Category
        Status