Sign upLogin

SquirrelJME/SquirrelJME

View on GitHub
Star

Showing 195 of 203 total issues

Consider simplifying this complex logical expression.
Open

        if (__r < 0 || __r > 255 || __g < 0 || __g > 255 || __b < 0 ||
            __b > 255)
            throw new IllegalArgumentException(String.format("DA01 %d %d %d",
                __r, __g, __b));
Severity: Major
Found in modules/meep-lui/src/main/java/javax/microedition/lui/DisplayColor.java - About 40 mins to fix

    Consider simplifying this complex logical expression.
    Open

                if (c == ',' || c == '"' ||
                (c <= ' ' && i == 0) || (c <= ' ' && i == (n - 1)))
                return true;
    Severity: Major
    Found in modules/csv/src/main/java/cc/squirreljme/csv/CsvWriter.java - About 40 mins to fix

      Consider simplifying this complex logical expression.
      Open

                  if (__show && (__form != null && current == __form) ||
                (__form == null && frame.isVisible() && current == null))
                return;
      Severity: Major
      Found in emulators/emulator-base/src/main/java/cc/squirreljme/emulator/uiform/SwingDisplay.java - About 40 mins to fix

        Consider simplifying this complex logical expression.
        Open

                            if ((includeMain && isMain) ||
                        (includeDaemon && isDaemon) ||
                        (!isMain && !isDaemon))
                        count++;
        Severity: Major
        Found in emulators/springcoat-vm/src/main/java/cc/squirreljme/vm/springcoat/MLEThread.java - About 40 mins to fix

          Consider simplifying this complex logical expression.
          Open

                  if (__srcOff < 0 || (__srcOff + __len) < 0 ||
                (__srcOff + __len) > srcLen ||
            __destOff < 0 || (__destOff + __len) < 0 ||
                (__destOff + __len) > destLen)
            throw new IndexOutOfBoundsException("IOOB");
          Severity: Major
          Found in modules/cldc-compact/src/main/java/cc/squirreljme/runtime/cldc/util/IntegerIntegerArray.java - About 40 mins to fix

            Consider simplifying this complex logical expression.
            Open

                    if (__jar == null || __jarOffset < 0 || __b == null ||
            __o < 0 || __l < 0 || (__o + __l) > __b.length)
            throw new MLECallError("Invalid parameters.");
            Severity: Major
            Found in emulators/emulator-base/src/main/java/cc/squirreljme/emulator/EmulatedJarPackageShelf.java - About 40 mins to fix

              Consider simplifying this complex logical expression.
              Open

                      if (__aotSettings == null || __settings == null ||
            __archive == null || __csv == null || __fileName == null ||
            __romSource == null)
            throw new NullPointerException("NARG");
              Severity: Major
              Found in modules/aot-nanocoat/src/main/java/cc/squirreljme/jvm/aot/nanocoat/NanoCoatBackend.java - About 40 mins to fix

                Consider simplifying this complex logical expression.
                Open

                            if (this.isPrivate() || this.isStatic() || this.isFinal() || this
                .isSynchronized() || this.isNative() || this.isStrict())
                throw new InvalidClassFormatException(
                    String.format("JC3l %s", this));
                Severity: Major
                Found in modules/tool-classfile/src/main/java/net/multiphasicapps/classfile/MethodFlags.java - About 40 mins to fix

                  Consider simplifying this complex logical expression.
                  Open

                          if (!(__v instanceof SpringObject) &&
            !(__v instanceof Boolean) &&
            !(__v instanceof Integer) &&
            !(__v instanceof Long) &&
            !(__v instanceof Float) &&
                  Severity: Major
                  Found in emulators/springcoat-vm/src/main/java/cc/squirreljme/vm/springcoat/SpringFieldStorage.java - About 40 mins to fix

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        @Api
    public static final class Builder
    {
        @Api
        public Builder()
                    Severity: Minor
                    Found in modules/dio-uart/src/main/java/jdk/dio/uart/UARTConfig.java and 1 other location - About 40 mins to fix
                    modules/dio-spibus/src/main/java/jdk/dio/spibus/SPIDeviceConfig.java on lines 158..232

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 130.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        @Api
    public static final class Builder
    {
        @Api
        public Builder()
                    Severity: Minor
                    Found in modules/dio-spibus/src/main/java/jdk/dio/spibus/SPIDeviceConfig.java and 1 other location - About 40 mins to fix
                    modules/dio-uart/src/main/java/jdk/dio/uart/UARTConfig.java on lines 218..292

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 130.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                    // -*- Mode: Java; indent-tabs-mode: t; tab-width: 4 -*-
// ---------------------------------------------------------------------------
// SquirrelJME
//     Copyright (C) Stephanie Gawroriski <xer@multiphasicapps.net>
// ---------------------------------------------------------------------------
                    Severity: Minor
                    Found in modules/cldc-compact/src/main/java/cc/squirreljme/runtime/cldc/util/SynchronizedEntrySetIterator.java and 1 other location - About 40 mins to fix
                    modules/cldc-compact/src/main/java/cc/squirreljme/runtime/cldc/util/SynchronizedEntrySetIteratorNotNull.java on lines 1..95

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 129.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                    // -*- Mode: Java; indent-tabs-mode: t; tab-width: 4 -*-
// ---------------------------------------------------------------------------
// SquirrelJME
//     Copyright (C) Stephanie Gawroriski <xer@multiphasicapps.net>
// ---------------------------------------------------------------------------
                    Severity: Minor
                    Found in modules/cldc-compact/src/main/java/cc/squirreljme/runtime/cldc/util/SynchronizedEntrySetIteratorNotNull.java and 1 other location - About 40 mins to fix
                    modules/cldc-compact/src/main/java/cc/squirreljme/runtime/cldc/util/SynchronizedEntrySetIterator.java on lines 1..93

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 129.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 3 locations. Consider refactoring.
                    Open

                        @Override
    public void setAlphaColor(int __a, int __r, int __g, int __b)
    {
        /* {@squirreljme.error EB2y Color out of range. (Alpha; Red; Green;
        Blue)} */
                    Severity: Minor
                    Found in modules/midp-lcdui/src/main/java/cc/squirreljme/runtime/lcdui/gfx/ProxyGraphics.java and 2 other locations - About 35 mins to fix
                    modules/midp-lcdui/src/main/java/cc/squirreljme/runtime/lcdui/gfx/AdvancedGraphics.java on lines 1132..1145
                    modules/midp-lcdui/src/main/java/cc/squirreljme/runtime/lcdui/mle/PencilGraphics.java on lines 866..879

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 127.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 3 locations. Consider refactoring.
                    Open

                        @Override
    public void setAlphaColor(int __a, int __r, int __g, int __b)
        throws IllegalArgumentException
    {
        /* {@squirreljme.error EB0f Color out of range. (Alpha; Red; Green;
                    Severity: Minor
                    Found in modules/midp-lcdui/src/main/java/cc/squirreljme/runtime/lcdui/gfx/AdvancedGraphics.java and 2 other locations - About 35 mins to fix
                    modules/midp-lcdui/src/main/java/cc/squirreljme/runtime/lcdui/gfx/ProxyGraphics.java on lines 509..521
                    modules/midp-lcdui/src/main/java/cc/squirreljme/runtime/lcdui/mle/PencilGraphics.java on lines 866..879

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 127.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 3 locations. Consider refactoring.
                    Open

                        @Override
    public void setAlphaColor(int __a, int __r, int __g, int __b)
        throws IllegalArgumentException
    {
        /* {@squirreljme.error EB3t Color out of range. (Alpha; Red; Green;
                    Severity: Minor
                    Found in modules/midp-lcdui/src/main/java/cc/squirreljme/runtime/lcdui/mle/PencilGraphics.java and 2 other locations - About 35 mins to fix
                    modules/midp-lcdui/src/main/java/cc/squirreljme/runtime/lcdui/gfx/AdvancedGraphics.java on lines 1132..1145
                    modules/midp-lcdui/src/main/java/cc/squirreljme/runtime/lcdui/gfx/ProxyGraphics.java on lines 509..521

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 127.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Method read has a Cognitive Complexity of 26 (exceeds 24 allowed). Consider refactoring.
                    Open

                        @Override
    public int read(char[] __c, int __o, int __l)
        throws IndexOutOfBoundsException, IOException, NullPointerException
    {
        if (__c == null)
                    Severity: Minor
                    Found in modules/io/src/main/java/net/multiphasicapps/io/Base64Encoder.java - About 35 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method read has a Cognitive Complexity of 26 (exceeds 24 allowed). Consider refactoring.
                    Open

                        public static final PCFFont read(InputStream __in)
        throws IOException, NullPointerException
    {
        if (__in == null)
            throw new NullPointerException("NARG");
                    Severity: Minor
                    Found in tools/pcf-to-sqf/src/main/java/net/multiphasicapps/pcftosqf/pcf/PCFFont.java - About 35 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method __formatOtherUnsignedInt has a Cognitive Complexity of 26 (exceeds 24 allowed). Consider refactoring.
                    Open

                        private static String __formatOtherUnsignedInt(__PrintFState__ __pf,
        Number __n, int __base)
        throws NullPointerException
    {
        if (__pf == null)
                    Severity: Minor
                    Found in modules/cldc-compact/src/main/java/java/util/Formatter.java - About 35 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method read has a Cognitive Complexity of 26 (exceeds 24 allowed). Consider refactoring.
                    Open

                        @Override
    public JsonStructure read()
    {
        synchronized (this.lock)
        {
                    Severity: Minor
                    Found in modules/json/src/main/java/net/multiphasicapps/jsr353/ImplReader.java - About 35 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Severity
                    Category
                    Status
                    Source
                    Language