Sign upLogin

SquirrelJME/SquirrelJME

View on GitHub
Star
modules/midp-lcdui/src/main/java/cc/squirreljme/runtime/lcdui/gfx/AdvancedGraphics.java

Summary

Maintainability
C
1 day
Test Coverage

File AdvancedGraphics.java has 1034 lines of code (exceeds 850 allowed). Consider refactoring.
Open

// -*- Mode: Java; indent-tabs-mode: t; tab-width: 4 -*-
// ---------------------------------------------------------------------------
// SquirrelJME
//     Copyright (C) Stephanie Gawroriski <xer@multiphasicapps.net>
// ---------------------------------------------------------------------------
Severity: Major
Found in modules/midp-lcdui/src/main/java/cc/squirreljme/runtime/lcdui/gfx/AdvancedGraphics.java - About 6 hrs to fix

    Method __drawText has a Cognitive Complexity of 32 (exceeds 24 allowed). Consider refactoring.
    Open

        final void __drawText(Text __t, int __x, int __y, int __anchor)
        throws NullPointerException
    {
        if (__t == null)
            throw new NullPointerException("NARG");
    Severity: Minor
    Found in modules/midp-lcdui/src/main/java/cc/squirreljme/runtime/lcdui/gfx/AdvancedGraphics.java - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Consider simplifying this complex logical expression.
    Open

            if (__a < 0 || __a > 255 || __r < 0 || __r > 255 ||
            __g < 0 || __g > 255 || __b < 0 || __b > 255)
            throw new IllegalArgumentException(String.format(
                "EB0f %d %d %d %d", __a, __r, __g, __b));
    Severity: Critical
    Found in modules/midp-lcdui/src/main/java/cc/squirreljme/runtime/lcdui/gfx/AdvancedGraphics.java - About 1 hr to fix

      Consider simplifying this complex logical expression.
      Open

              if (__x1 < clipsx || __x2 < clipsx || __y1 < clipsy || __y2 < clipsy ||
            __x1 > clipex || __x2 > clipex || __y1 > clipey || __y2 > clipey)
            return;
      Severity: Critical
      Found in modules/midp-lcdui/src/main/java/cc/squirreljme/runtime/lcdui/gfx/AdvancedGraphics.java - About 1 hr to fix

        Method __drawText has 108 lines of code (exceeds 100 allowed). Consider refactoring.
        Open

            final void __drawText(Text __t, int __x, int __y, int __anchor)
        throws NullPointerException
    {
        if (__t == null)
            throw new NullPointerException("NARG");
        Severity: Major
        Found in modules/midp-lcdui/src/main/java/cc/squirreljme/runtime/lcdui/gfx/AdvancedGraphics.java - About 1 hr to fix

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

              @Override
    public void setAlphaColor(int __a, int __r, int __g, int __b)
        throws IllegalArgumentException
    {
        /* {@squirreljme.error EB0f Color out of range. (Alpha; Red; Green;
          Severity: Minor
          Found in modules/midp-lcdui/src/main/java/cc/squirreljme/runtime/lcdui/gfx/AdvancedGraphics.java and 2 other locations - About 35 mins to fix
          modules/midp-lcdui/src/main/java/cc/squirreljme/runtime/lcdui/gfx/ProxyGraphics.java on lines 509..521
          modules/midp-lcdui/src/main/java/cc/squirreljme/runtime/lcdui/mle/PencilGraphics.java on lines 866..879

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 127.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status