StellarCN/py-stellar-base

View on GitHub

Showing 1,842 of 1,842 total issues

Method "__init__" has 9 parameters, which is greater than the 7 authorized.
Open

        self,
        horizon_url: str,
        client: BaseSyncClient,
        base: Asset,
        counter: Asset,

A long parameter list can indicate that a new structure should be created to wrap the numerous parameters or that the function is doing too many things.

Noncompliant Code Example

With a maximum number of 4 parameters:

def do_something(param1, param2, param3, param4, param5):
    ...

Compliant Solution

def do_something(param1, param2, param3, param4):
    ...

Method "__init__" has 9 parameters, which is greater than the 7 authorized.
Open

        self,
        horizon_url: str,
        client: BaseAsyncClient,
        base: Asset,
        counter: Asset,

A long parameter list can indicate that a new structure should be created to wrap the numerous parameters or that the function is doing too many things.

Noncompliant Code Example

With a maximum number of 4 parameters:

def do_something(param1, param2, param3, param4, param5):
    ...

Compliant Solution

def do_something(param1, param2, param3, param4):
    ...
Severity
Category
Status
Source
Language