Stromweld/autopatch_ii

View on GitHub

Showing 4 of 4 total issues

Method next_monthly_date has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def self.next_monthly_date(monthly_specifier, hour, minute, time_zone_name)
        desired_tz_offset = if time_zone_name
                              TZInfo::Timezone.get(time_zone_name).current_period.utc_total_offset
                            else
                              Time.now.utc_offset
Severity: Minor
Found in libraries/autopatch.rb - About 1 hr to fix

    Method next_monthly_date has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

          def self.next_monthly_date(monthly_specifier, hour, minute, time_zone_name)
            desired_tz_offset = if time_zone_name
                                  TZInfo::Timezone.get(time_zone_name).current_period.utc_total_offset
                                else
                                  Time.now.utc_offset
    Severity: Minor
    Found in libraries/autopatch.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid deeply nested control flow statements.
    Open

            elsif node['autopatch_ii']['disable'] == false
              node.override['autopatch_ii']['disable'] = true
              node.override['autopatch_ii']['private_lin_autopatch_disabled_programmatically'] = true
              Chef::Log.debug("Disabling autopatch_ii for month #{DateTime.now.strftime('%^b')}!!")
    Severity: Major
    Found in recipes/linux.rb - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                if node['autopatch_ii']['private_lin_autopatch_disabled_programmatically'] == true
                  if node['autopatch_ii']['disable'] == true
                    # Re-enable it
                    Chef::Log.debug("Re-enabling autopatch_ii for month #{DateTime.now.strftime('%^b')}")
                    node.override['autopatch_ii']['disable'] = false
      Severity: Major
      Found in recipes/linux.rb - About 45 mins to fix
        Severity
        Category
        Status
        Source
        Language