TYPO3-Initiatives/adminpanel-extended

View on GitHub

Showing 6 of 14 total issues

Function getSignalData has 61 lines of code (exceeds 25 allowed). Consider refactoring.
Open

Signals.getSignalData = function (event) {
    event.preventDefault();
    const uri = this.dataset.typo3AjaxUrl;
    const request = new XMLHttpRequest();
    request.open('GET', uri);
Severity: Major
Found in Resources/Public/JavaScript/Signals.js - About 2 hrs to fix

    Function getSignalData has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
    Open

    Signals.getSignalData = function (event) {
        event.preventDefault();
        const uri = this.dataset.typo3AjaxUrl;
        const request = new XMLHttpRequest();
        request.open('GET', uri);
    Severity: Minor
    Found in Resources/Public/JavaScript/Signals.js - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Missing class import via use statement (line '29', column '23').
    Open

                throw new \RuntimeException(sprintf('Directory "%s" could not be created', self::EXTENSION_DIRECTORY));
    Severity: Minor
    Found in Classes/Composer/ScriptHelper.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '68', column '23').
    Open

                throw new \InvalidArgumentException(

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Avoid unused parameters such as '$request'.
    Open

        public function getDataToStore(ServerRequestInterface $request): ModuleData
    Severity: Minor
    Found in Classes/Modules/Fluid/General.php by phpmd

    UnusedFormalParameter

    Since: 0.2

    Avoid passing parameters to methods or constructors and then not using those parameters.

    Example

    class Foo
    {
        private function bar($howdy)
        {
            // $howdy is not used
        }
    }

    Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

    Avoid assigning values to variables in if clauses and the like (line '27', column '20').
    Open

        public static function ensureExtensionStructure(): void
        {
            if (!is_dir(self::EXTENSION_DIRECTORY) &&
                !mkdir($concurrentDirectory = self::EXTENSION_DIRECTORY, 0775, true) &&
                !is_dir($concurrentDirectory)) {
    Severity: Minor
    Found in Classes/Composer/ScriptHelper.php by phpmd

    IfStatementAssignment

    Since: 2.7.0

    Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

    Example

    class Foo
    {
        public function bar($flag)
        {
            if ($foo = 'bar') { // possible typo
                // ...
            }
            if ($baz = 0) { // always false
                // ...
            }
        }
    }

    Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

    Severity
    Category
    Status
    Source
    Language