TabbycatDebate/tabbycat

View on GitHub
tabbycat/draw/generator/__init__.py

Summary

Maintainability
B
4 hrs
Test Coverage
F
54%

Function DrawGenerator has a Cognitive Complexity of 27 (exceeds 8 allowed). Consider refactoring.
Open

def DrawGenerator(teams_per_debate, draw_type, teams, results=None, rrseq=None, **kwargs):  # noqa: N802 (factory function)
    """Factory for draw objects.
    Takes a list of options and returns an appropriate subclass of BaseDrawGenerator.
    'draw_type' is mandatory and can be any of 'random', 'power_paired',
        'first_elimination' and 'elimination'.
Severity: Minor
Found in tabbycat/draw/generator/__init__.py - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function DrawGenerator has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

def DrawGenerator(teams_per_debate, draw_type, teams, results=None, rrseq=None, **kwargs):  # noqa: N802 (factory function)
Severity: Minor
Found in tabbycat/draw/generator/__init__.py - About 45 mins to fix

    There are no issues that match your filters.

    Category
    Status