TabbycatDebate/tabbycat

View on GitHub
tabbycat/draw/tables.py

Summary

Maintainability
B
4 hrs
Test Coverage
F
22%

Cyclomatic complexity is too high in method build. (15)
Open

    def build(self, draw, teams, side_histories_before, side_histories_now, standings):
        self.side_histories_before = side_histories_before
        self.side_histories_now = side_histories_now
        self.standings = standings

Severity: Minor
Found in tabbycat/draw/tables.py by radon

Cyclomatic Complexity

Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

Construct Effect on CC Reasoning
if +1 An if statement is a single decision.
elif +1 The elif statement adds another decision.
else +0 The else statement does not cause a new decision. The decision is at the if.
for +1 There is a decision at the start of the loop.
while +1 There is a decision at the while statement.
except +1 Each except branch adds a new conditional path of execution.
finally +0 The finally block is unconditionally executed.
with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
assert +1 The assert statement internally roughly equals a conditional statement.
Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

Source: http://radon.readthedocs.org/en/latest/intro.html

Function add_debate_team_columns has a Cognitive Complexity of 12 (exceeds 8 allowed). Consider refactoring.
Open

    def add_debate_team_columns(self, debates, highlight=[]):
        all_sides_confirmed = all(debate.sides_confirmed for debate in debates)  # should already be fetched

        for i, side in enumerate(self.tournament.sides, start=1):
            # For BP team names are often longer than the full position label
Severity: Minor
Found in tabbycat/draw/tables.py - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _add_debate_standing_columns has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def _add_debate_standing_columns(self, debates, standings, itermethod, infomethod, formattext, formatsort, limit=None):
Severity: Major
Found in tabbycat/draw/tables.py - About 50 mins to fix

    Function build has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def build(self, draw, teams, side_histories_before, side_histories_now, standings):
    Severity: Minor
    Found in tabbycat/draw/tables.py - About 35 mins to fix

      Function build has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def build(self, debates, teams, side_histories_before, side_histories_now, standings):
      Severity: Minor
      Found in tabbycat/draw/tables.py - About 35 mins to fix

        Function _add_debate_standing_columns has a Cognitive Complexity of 10 (exceeds 8 allowed). Consider refactoring.
        Open

            def _add_debate_standing_columns(self, debates, standings, itermethod, infomethod, formattext, formatsort, limit=None):
                standings_by_debate = [standings.get_standings(
                        [d.get_team(side) for side in self.tournament.sides]) for d in debates]
                cells = []
        
        
        Severity: Minor
        Found in tabbycat/draw/tables.py - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this function.
        Open

                    return "danger", "still-bad", 2
        Severity: Major
        Found in tabbycat/draw/tables.py - About 30 mins to fix

          There are no issues that match your filters.

          Category
          Status