TabbycatDebate/tabbycat

View on GitHub
tabbycat/results/views.py

Summary

Maintainability
A
3 hrs
Test Coverage
F
46%

Cyclomatic complexity is too high in method populate_objects. (11)
Open

    def populate_objects(self):
        self.object = self.get_object() # must be populated before self.error_page() called

        round = self.tournament.current_round
        if round.draw_status != Round.STATUS_RELEASED:
Severity: Minor
Found in tabbycat/results/views.py by radon

Cyclomatic Complexity

Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

Construct Effect on CC Reasoning
if +1 An if statement is a single decision.
elif +1 The elif statement adds another decision.
else +0 The else statement does not cause a new decision. The decision is at the if.
for +1 There is a decision at the start of the loop.
while +1 There is a decision at the while statement.
except +1 Each except branch adds a new conditional path of execution.
finally +0 The finally block is unconditionally executed.
with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
assert +1 The assert statement internally roughly equals a conditional statement.
Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

Source: http://radon.readthedocs.org/en/latest/intro.html

Function get_irons_list has a Cognitive Complexity of 11 (exceeds 8 allowed). Consider refactoring.
Open

    def get_irons_list(self):
        iron_speeches = []
        use_code_names = use_team_code_names_data_entry(self.tournament, True)
        for d in self._get_draw():
            for side in self.tournament.sides:
Severity: Minor
Found in tabbycat/results/views.py - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

            return self.error_page(_("It looks like the sides for this debate haven't yet been confirmed, "
Severity: Major
Found in tabbycat/results/views.py - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

                return self.error_page(_("Your debate doesn't have a chair, so you can't enter results for it. "
    Severity: Major
    Found in tabbycat/results/views.py - About 30 mins to fix

      Function populate_objects has a Cognitive Complexity of 9 (exceeds 8 allowed). Consider refactoring.
      Open

          def populate_objects(self):
              self.object = self.get_object() # must be populated before self.error_page() called
      
              round = self.tournament.current_round
              if round.draw_status != Round.STATUS_RELEASED:
      Severity: Minor
      Found in tabbycat/results/views.py - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              if not (self.tournament.pref('draw_side_allocations') == 'manual-ballot' and
                      self.tournament.pref('teams_in_debate') == 'two') and not self.debate.sides_confirmed:
      Severity: Minor
      Found in tabbycat/results/views.py and 1 other location - About 35 mins to fix
      tabbycat/results/views.py on lines 503..504

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 51.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              if not (self.tournament.pref('draw_side_allocations') == 'manual-ballot' and
                      self.tournament.pref('teams_in_debate') == 'two') and not self.debate.sides_confirmed:
      Severity: Minor
      Found in tabbycat/results/views.py and 1 other location - About 35 mins to fix
      tabbycat/results/views.py on lines 380..381

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 51.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status