TabbycatDebate/tabbycat

View on GitHub
tabbycat/results/views.py

Summary

Maintainability
B
7 hrs
Test Coverage
F
46%

File views.py has 690 lines of code (exceeds 600 allowed). Consider refactoring.
Open

import logging

from asgiref.sync import async_to_sync
from channels.layers import get_channel_layer
from django.conf import settings
Severity: Major
Found in tabbycat/results/views.py - About 4 hrs to fix

    Cyclomatic complexity is too high in method populate_objects. (15)
    Open

        def populate_objects(self, prefill=True):
            self.object = self.get_object() # must be populated before self.error_page() called
    
            if self.round.draw_status != Round.STATUS_RELEASED:
                return self.error_page(_("The draw for this round hasn't been released yet."))
    Severity: Minor
    Found in tabbycat/results/views.py by radon

    Cyclomatic Complexity

    Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

    Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

    Construct Effect on CC Reasoning
    if +1 An if statement is a single decision.
    elif +1 The elif statement adds another decision.
    else +0 The else statement does not cause a new decision. The decision is at the if.
    for +1 There is a decision at the start of the loop.
    while +1 There is a decision at the while statement.
    except +1 Each except branch adds a new conditional path of execution.
    finally +0 The finally block is unconditionally executed.
    with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
    assert +1 The assert statement internally roughly equals a conditional statement.
    Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
    Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

    Source: http://radon.readthedocs.org/en/latest/intro.html

    Function populate_objects has a Cognitive Complexity of 13 (exceeds 8 allowed). Consider refactoring.
    Open

        def populate_objects(self, prefill=True):
            self.object = self.get_object() # must be populated before self.error_page() called
    
            if self.round.draw_status != Round.STATUS_RELEASED:
                return self.error_page(_("The draw for this round hasn't been released yet."))
    Severity: Minor
    Found in tabbycat/results/views.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function get_irons_list has a Cognitive Complexity of 11 (exceeds 8 allowed). Consider refactoring.
    Open

        def get_irons_list(self):
            iron_speeches = []
            use_code_names = use_team_code_names_data_entry(self.tournament, True)
            for d in self._get_draw():
                for side in self.tournament.sides:
    Severity: Minor
    Found in tabbycat/results/views.py - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this function.
    Open

                return self.error_page(_("It looks like the sides for this debate haven't yet been confirmed, "
    Severity: Major
    Found in tabbycat/results/views.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                  return self.error_page(_("Your debate doesn't have a chair, so you can't enter results for it. "
      Severity: Major
      Found in tabbycat/results/views.py - About 30 mins to fix

        TODO found
        Open

                    # TODO: The select_related() call above avoids an N+1 issue in the
        Severity: Minor
        Found in tabbycat/results/views.py by fixme

        There are no issues that match your filters.

        Category
        Status