TabbycatDebate/tabbycat

View on GitHub
tabbycat/tournaments/models.py

Summary

Maintainability
C
1 day
Test Coverage
C
75%

Round has 26 functions (exceeds 20 allowed). Consider refactoring.
Open

class Round(models.Model):
    DRAW_RANDOM = 'R'
    DRAW_MANUAL = 'M'
    DRAW_ROUNDROBIN = 'D'
    DRAW_POWERPAIRED = 'P'
Severity: Minor
Found in tabbycat/tournaments/models.py - About 3 hrs to fix

    Cyclomatic complexity is too high in method debate_set_with_prefetches. (18)
    Open

        def debate_set_with_prefetches(self, filter_kwargs=None, ordering=('venue__name',),
                teams=True, adjudicators=True, speakers=True, wins=False,
                results=False, venues=True, institutions=False, check_ins=False, iron=False):
            """Returns the debate set, with aff_team and neg_team populated.
            This is basically a prefetch-like operation, except that it also figures
    Severity: Minor
    Found in tabbycat/tournaments/models.py by radon

    Cyclomatic Complexity

    Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

    Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

    Construct Effect on CC Reasoning
    if +1 An if statement is a single decision.
    elif +1 The elif statement adds another decision.
    else +0 The else statement does not cause a new decision. The decision is at the if.
    for +1 There is a decision at the start of the loop.
    while +1 There is a decision at the while statement.
    except +1 Each except branch adds a new conditional path of execution.
    finally +0 The finally block is unconditionally executed.
    with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
    assert +1 The assert statement internally roughly equals a conditional statement.
    Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
    Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

    Source: http://radon.readthedocs.org/en/latest/intro.html

    Tournament has 25 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class Tournament(models.Model):
        name = models.CharField(max_length=100,
            verbose_name=_("name"),
            help_text=_("The full name, e.g. \"Australasian Intervarsity Debating Championships 2016\""))
        short_name = models.CharField(max_length=25, blank=True, default="",
    Severity: Minor
    Found in tabbycat/tournaments/models.py - About 2 hrs to fix

      Function debate_set_with_prefetches has a Cognitive Complexity of 17 (exceeds 8 allowed). Consider refactoring.
      Open

          def debate_set_with_prefetches(self, filter_kwargs=None, ordering=('venue__name',),
                  teams=True, adjudicators=True, speakers=True, wins=False,
                  results=False, venues=True, institutions=False, check_ins=False, iron=False):
              """Returns the debate set, with aff_team and neg_team populated.
              This is basically a prefetch-like operation, except that it also figures
      Severity: Minor
      Found in tabbycat/tournaments/models.py - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function debate_set_with_prefetches has 12 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def debate_set_with_prefetches(self, filter_kwargs=None, ordering=('venue__name',),
      Severity: Major
      Found in tabbycat/tournaments/models.py - About 1 hr to fix

        There are no issues that match your filters.

        Category
        Status