Sign upLogin

Tehsurfer/collectiondbf

View on GitHub
Star

Showing 2 of 2 total issues

Function run has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Confirmed

def run():

    args = argparse_setup()
    config = config_file()
Severity: Minor
Found in collectiondbf/command_line.py - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function downloading_blackfynn_package has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

def downloading_blackfynn_package(item, collection, file_path):
    if 'files' in dir(item):
        for file in item.files:
            file_type = get_file_type(file.s3_key)
            new_file_path = os.path.join(file_path, collection.name, file.name + '.' + file_type)
Severity: Minor
Found in collectiondbf/command_line.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language